Bug 97733

Summary: ApplicationCacheStorage does not optimilay handle 8 bit strings
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: Page LoadingAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ap: review+

Michael Saboff
Reported 2012-09-26 15:19:39 PDT
I several places, ApplicationCacheStorage calls characters() on strings, which will up convert an 8 bit string to 16 bits.
Attachments
Patch (3.84 KB, patch)
2012-09-26 16:02 PDT, Michael Saboff 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-09-26 16:02:07 PDT
Created attachment 165890 [details] Patch
Darin Adler
Comment 2 2012-09-27 10:51:37 PDT
Comment on attachment 165890 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165890&action=review > Source/WebCore/ChangeLog:3 > + ApplicationCacheStorage does not properly handle 8 bit strings In the future for patches like this I suggest more precise phrasing, because the code did correctly work if passed 8 bit strings before. I’d say something more like “converts 8-bit strings into 16-bit unnecessarily” or mention performance. The phrase “does not properly handle” sounds like we’ll get incorrect results, but this patch is about performance optimization, not correctness.
Michael Saboff
Comment 3 2012-09-27 12:04:44 PDT
Committed r129786: <http://trac.webkit.org/changeset/129786>
Note You need to log in before you can comment on or make changes to this bug.