Bug 97718

Summary: [BlackBerry] Remove blitContents() in favor of blitVisibleContents()
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: WebKit BlackBerryAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, manyoso, mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jakob Petsovits
Reported 2012-09-26 12:52:11 PDT
After the last calling sites of blitContents() have been removed or reworked, the actual method itself can now retire. All blits now go through blitVisibleContents(). The knowledge that we always blit the full visible surface can facilitate further optimizations; we will get to that in time. Patch below.
Attachments
Patch (12.68 KB, patch)
2012-09-26 13:07 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Patch (12.85 KB, patch)
2012-09-26 13:33 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2012-09-26 13:07:51 PDT
Created attachment 165859 [details] Patch
WebKit Review Bot
Comment 2 2012-09-26 13:10:49 PDT
Attachment 165859 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/BackingStore...." exit_code: 1 Source/WebKit/blackberry/Api/BackingStore.cpp:1278: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jakob Petsovits
Comment 3 2012-09-26 13:33:53 PDT
Created attachment 165866 [details] Patch Try to satisfy the stylebot.
WebKit Review Bot
Comment 4 2012-09-26 14:11:03 PDT
Comment on attachment 165866 [details] Patch Clearing flags on attachment: 165866 Committed r129706: <http://trac.webkit.org/changeset/129706>
WebKit Review Bot
Comment 5 2012-09-26 14:11:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.