Bug 97710 – REGRESSION(r129521): Broke autocomplete on enter_bug.cgi (Requested by abarth on #webkit).

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Review Bot]

http://trac.webkit.org/changeset/129521 broke the build:
Broke autocomplete on enter_bug.cgi (Requested by abarth on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 165839 [details]
ROLLOUT of r129521

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Adam Barth]

Comment on attachment 165839 [details]
ROLLOUT of r129521

View in context: https://bugs.webkit.org/attachment.cgi?id=165839&action=review

> Websites/bugs.webkit.org/committers-autocomplete.js:401
> -    for (var i = 0; i < EMAIL_INPUTS.length; i++) {
> -        var field = document.getElementById(EMAIL_INPUTS[i]);
> -        if (field)
> -            field.addEventListener("focus", function(e) { enableAutoComplete(e.target); }, false);
> -    }
> +    document.addEventListener('focusin', function(e) {
> +        for (var i = 0; i < EMAIL_INPUTS.length; i++) {
> +            if (e.target.name == EMAIL_INPUTS[i]) {
> +                enableAutoComplete(e.target);
> +                break;
> +            }
> +        }
> +    }, false);

The problem is you changed this from looking at the "name" to looking at the "id".  On enter_bug, we have a name but no ID.

[WebKit Review Bot]

Comment on attachment 165839 [details]
ROLLOUT of r129521

Clearing flags on attachment: 165839

Committed r129677: <http://trac.webkit.org/changeset/129677>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.