Bug 97702

Summary: REGRESSION(r129654): breaks chromium windows build (Requested by schenney on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Severity: Normal CC: abarth, schenney
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95193    
Description Flags
ROLLOUT of r129654 none

Description WebKit Review Bot 2012-09-26 10:58:40 PDT
http://trac.webkit.org/changeset/129654 broke the build:
breaks chromium windows build (Requested by schenney on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-09-26 10:59:28 PDT
Created attachment 165832 [details]
ROLLOUT of r129654

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Stephen Chenney 2012-09-26 11:06:42 PDT
C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/PassRefPtr.h(53): error C2027: use of undefined type 'WebCore::RTCStatsRequest'
6>          C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WebCore\platform\mediastream\RTCPeerConnectionHandler.h(48) : see declaration of 'WebCore::RTCStatsRequest'
6>          C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/PassRefPtr.h(68) : see reference to function template instantiation 'void WTF::derefIfNotNull<T>(T *)' being compiled
6>          with
6>          [
6>              T=WebCore::RTCStatsRequest
6>          ]
6>          C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/PassRefPtr.h(68) : while compiling class template member function 'WTF::PassRefPtr<T>::~PassRefPtr(void)'
6>          with
6>          [
6>              T=WebCore::RTCStatsRequest
6>          ]
6>          ..\platform\mediastream\chromium\RTCPeerConnectionHandlerChromium.cpp(161) : see reference to class template instantiation 'WTF::PassRefPtr<T>' being compiled
6>          with
6>          [
6>              T=WebCore::RTCStatsRequest
6>          ]
6>C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/PassRefPtr.h(53): error C2227: left of '->deref' must point to class/struct/union/generic type
Comment 3 WebKit Review Bot 2012-09-26 11:11:29 PDT
Comment on attachment 165832 [details]
ROLLOUT of r129654

Clearing flags on attachment: 165832

Committed r129672: <http://trac.webkit.org/changeset/129672>
Comment 4 WebKit Review Bot 2012-09-26 11:11:33 PDT
All reviewed patches have been landed.  Closing bug.