Bug 97690

Summary: Unify event handling of middle mouse button
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: UI EventsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, gustavo, menard, tony, webkit.review.bot, zoltan
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Allan Sandfeld Jensen
Reported 2012-09-26 08:50:27 PDT
Each of the ports with X11 backends have separate implementation of pasting the global selection. In the bug #88238 the code pasting the selection was unified for Chromium and Qt WebKit1 and Qt WebKit2, but they still had separate event handling. The event handling should also be unified, and it should attempt to include the similar code for GTK as well.
Attachments
Patch (16.39 KB, patch)
2012-09-26 08:54 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (16.49 KB, patch)
2012-09-26 09:27 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.62 KB, patch)
2012-09-27 02:55 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-09-26 08:54:27 PDT
Created attachment 165816 [details] Patch
Allan Sandfeld Jensen
Comment 2 2012-09-26 09:27:59 PDT
Created attachment 165823 [details] Patch Rebased
Tony Chang
Comment 3 2012-09-26 12:02:55 PDT
Comment on attachment 165823 [details] Patch Thanks for doing this refactoring!
Allan Sandfeld Jensen
Comment 4 2012-09-27 02:55:32 PDT
Created attachment 165959 [details] Patch for landing Missed support in GTK WebKit1
WebKit Review Bot
Comment 5 2012-09-27 04:11:55 PDT
Comment on attachment 165959 [details] Patch for landing Clearing flags on attachment: 165959 Committed r129750: <http://trac.webkit.org/changeset/129750>
WebKit Review Bot
Comment 6 2012-09-27 04:11:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.