Bug 97690

Summary: Unify event handling of middle mouse button
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: UI EventsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, gustavo, menard, tony, webkit.review.bot, zoltan
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Allan Sandfeld Jensen 2012-09-26 08:50:27 PDT
Each of the ports with X11 backends have separate implementation of pasting the global selection. In the bug #88238 the code pasting the selection was unified for Chromium and Qt WebKit1 and Qt WebKit2, but they still had separate event handling.

The event handling should also be unified, and it should attempt to include the similar code for GTK as well.
Comment 1 Allan Sandfeld Jensen 2012-09-26 08:54:27 PDT
Created attachment 165816 [details]
Patch
Comment 2 Allan Sandfeld Jensen 2012-09-26 09:27:59 PDT
Created attachment 165823 [details]
Patch

Rebased
Comment 3 Tony Chang 2012-09-26 12:02:55 PDT
Comment on attachment 165823 [details]
Patch

Thanks for doing this refactoring!
Comment 4 Allan Sandfeld Jensen 2012-09-27 02:55:32 PDT
Created attachment 165959 [details]
Patch for landing

Missed support in GTK WebKit1
Comment 5 WebKit Review Bot 2012-09-27 04:11:55 PDT
Comment on attachment 165959 [details]
Patch for landing

Clearing flags on attachment: 165959

Committed r129750: <http://trac.webkit.org/changeset/129750>
Comment 6 WebKit Review Bot 2012-09-27 04:11:58 PDT
All reviewed patches have been landed.  Closing bug.