Summary: | [Chromium] Fix find-in-page corner case for detached frames | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leandro Graciá Gil <leandrogracia> | ||||||
Component: | WebKit Misc. | Assignee: | Leandro Graciá Gil <leandrogracia> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Leandro Graciá Gil
2012-09-26 08:45:57 PDT
Created attachment 165813 [details]
Patch
Comment on attachment 165813 [details] Patch Attachment 165813 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14030525 Comment on attachment 165813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165813&action=review We really need better testing for this feature. I don't want to hold up this patch over lack of testing, but that's the reason we're having these sorts of troubles. > Source/WebKit/chromium/src/WebFrameImpl.cpp:1734 > - if (frame() && frame()->editor()->markedTextMatchesAreHighlighted()) > + if (frame() && frame->page() && frame()->editor()->markedTextMatchesAreHighlighted()) frame -> frame() Created attachment 165822 [details]
Patch
Comment on attachment 165813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165813&action=review >> Source/WebKit/chromium/src/WebFrameImpl.cpp:1734 >> + if (frame() && frame->page() && frame()->editor()->markedTextMatchesAreHighlighted()) > > frame -> frame() Fixed. Sorry for the nit. (In reply to comment #3) > (From update of attachment 165813 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165813&action=review > > We really need better testing for this feature. I don't want to hold up this patch over lack of testing, but that's the reason we're having these sorts of troubles. Completely agree. It proved to be trickier than it seems and with corner cases that need proper coverage. Comment on attachment 165822 [details]
Patch
ok...
Comment on attachment 165822 [details] Patch Clearing flags on attachment: 165822 Committed r129666: <http://trac.webkit.org/changeset/129666> All reviewed patches have been landed. Closing bug. |