Bug 97649

Summary: [Forms] Copy TimeInputType.{cpp,h} to BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97521    
Attachments:
Description Flags
Patch 1 tkent: review+, buildbot: commit-queue-

yosin
Reported 2012-09-26 02:28:02 PDT
To share code for multiple fields input type among date/time input types, we would like to introduce new class BaseMultipleFieldsDateAndTimeInputType.
Attachments
Patch 1 (18.12 KB, patch)
2012-09-26 02:42 PDT, yosin 		tkent: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-09-26 02:42:53 PDT
Created attachment 165760 [details] Patch 1
yosin
Comment 2 2012-09-26 02:43:41 PDT
Comment on attachment 165760 [details] Patch 1 Could you review this patch? Thanks in advance. Note: This patch is results of "svn copy".
WebKit Review Bot
Comment 3 2012-09-26 02:47:09 PDT
Attachment 165760 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h:31: #ifndef header guard has wrong style, please use: BaseMultipleFieldsDateAndTimeInputType_h [build/header_guard] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 4 2012-09-26 03:02:48 PDT
Comment on attachment 165760 [details] Patch 1 Attachment 165760 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14038235
Kent Tamura
Comment 5 2012-09-26 03:21:42 PDT
Comment on attachment 165760 [details] Patch 1 ok
yosin
Comment 6 2012-09-26 18:25:54 PDT
Landed: http://trac.webkit.org/changeset/129721
Note You need to log in before you can comment on or make changes to this bug.