Bug 97614 – AX: AccessibilityUIElementChromium.cpp won't build on Windows without wtf/StringExtras.h

• Component: Accessibility
• Status: RESOLVED FIXED

[Dominic Mazzoni]

AccessibilityUIElementChromium.cpp calls snprintf as of r129527 - this is fine, but it won't build on Windows without wtf/StringExtras.h because the MS VC++ compiler doesn't have snprintf built-in.

[Dominic Mazzoni]

Created attachment 165693 [details]
Patch

[WebKit Review Bot]

Comment on attachment 165693 [details]
Patch

Rejecting attachment 165693 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
it/webkit-commit-queue

Parsed 2 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp
Hunk #1 FAILED at 37.
1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14033203

[Alec Flett]

Comment on attachment 165693 [details]
Patch

I landed this when I realized the commit-queue would take too long.

[Alec Flett]

Committed r129568: <http://trac.webkit.org/changeset/129568>