Bug 97577

Summary: [CSSRegions]Refactor RenderFlowThread::contentLogical(Width/Height/Left)OfFirstRegion
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Mihnea Ovidenie
Reported 2012-09-25 10:45:51 PDT
Make all of them use RenderFlowThread::firstRegion() instead of duplicating code.
Attachments
Patch (4.17 KB, patch)
2012-09-25 10:53 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.38 KB, patch)
2012-09-26 22:58 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2012-09-25 10:53:02 PDT
Created attachment 165641 [details] Patch
Andreas Kling
Comment 2 2012-09-26 07:52:44 PDT
Comment on attachment 165641 [details] Patch r=me
WebKit Review Bot
Comment 3 2012-09-26 08:20:11 PDT
Comment on attachment 165641 [details] Patch Rejecting attachment 165641 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Reorder Qt WebCore includes When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/14036446
Mihnea Ovidenie
Comment 4 2012-09-26 22:58:18 PDT
Created attachment 165932 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-09-27 00:52:51 PDT
Comment on attachment 165932 [details] Patch for landing Clearing flags on attachment: 165932 Committed r129733: <http://trac.webkit.org/changeset/129733>
WebKit Review Bot
Comment 6 2012-09-27 00:52:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.