Bug 97572

Summary: [GTK] Enable some of the unstable CSS features
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, philn, pnormand, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mrobinson: review+

Zan Dobersek
Reported 2012-09-25 09:44:52 PDT
[GTK] Enable some of the unstable CSS features
Attachments
Patch (10.82 KB, patch)
2012-09-25 09:53 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (12.24 KB, patch)
2012-09-25 10:13 PDT, Zan Dobersek 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-09-25 09:53:30 PDT
Created attachment 165634 [details] Patch
Zan Dobersek
Comment 2 2012-09-25 09:55:33 PDT
(In reply to comment #1) > Created an attachment (id=165634) [details] > Patch This patch enables CSS sticky position, CSS3 text decoration and <style scoped> features in developer builds. Also enables the related tests. Note that complete rebuilds will be required on the builders after landing this.
WebKit Review Bot
Comment 3 2012-09-25 09:57:57 PDT
Attachment 165634 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:122: The parameter name "enabled" adds no information, so it should be removed. [readability/parameter_name] [5] WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 4 2012-09-25 10:13:32 PDT
Created attachment 165636 [details] Patch
WebKit Review Bot
Comment 5 2012-09-25 10:18:33 PDT
Attachment 165636 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:122: The parameter name "enabled" adds no information, so it should be removed. [readability/parameter_name] [5] WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 6 2012-09-25 10:22:50 PDT
Comment on attachment 165636 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165636&action=review >> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:122 >> + static void setStyleScopedEnabled(bool enabled); > > The parameter name "enabled" adds no information, so it should be removed. [readability/parameter_name] [5] Please fix this before landing.
Zan Dobersek
Comment 7 2012-09-26 00:46:11 PDT
(In reply to comment #6) > (From update of attachment 165636 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165636&action=review > > >> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:122 > >> + static void setStyleScopedEnabled(bool enabled); > > > > The parameter name "enabled" adds no information, so it should be removed. [readability/parameter_name] [5] > > Please fix this before landing. Done. Landed in r129604. http://trac.webkit.org/changeset/129604
Note You need to log in before you can comment on or make changes to this bug.