Bug 97562

Summary: [GTK] Add WebKit1-specific TestExpectations file
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, mrobinson, ojan, pdr, svillar, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2012-09-25 06:16:05 PDT
[GTK] Add WebKit1-specific TestExpectations file
Attachments
Patch (8.04 KB, patch)
2012-09-25 06:20 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (9.42 KB, patch)
2012-12-20 02:48 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-09-25 06:20:23 PDT
Created attachment 165599 [details] Patch
Sergio Villar Senin
Comment 2 2012-09-25 06:44:16 PDT
I guess the question here is why? We already have one
Zan Dobersek
Comment 3 2012-09-25 07:19:53 PDT
(In reply to comment #2) > I guess the question here is why? We already have one 'One' what, exactly? There's no gtk-wk1 TestExpectations file yet, but there's a section in the gtk-wk2 TestExpectations file that contains all the tests that pass on WK2 builders but fail on WK1. The intention of the gtk-wk1 TestExpectations is to contain expectations for such tests.
Sergio Villar Senin
Comment 4 2012-09-25 07:42:05 PDT
(In reply to comment #3) > (In reply to comment #2) > > I guess the question here is why? We already have one > > 'One' what, exactly? There's no gtk-wk1 TestExpectations file yet, but there's a section in the gtk-wk2 TestExpectations file that contains all the tests that pass on WK2 builders but fail on WK1. The intention of the gtk-wk1 TestExpectations is to contain expectations for such tests. We have a TestExpectations file for wk1 in gtk/. The exceptions we added in the wk2 file are there just because run-webkit-tests picks them both when run with "-2".
Zan Dobersek
Comment 5 2012-09-25 07:51:58 PDT
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > I guess the question here is why? We already have one > > > > 'One' what, exactly? There's no gtk-wk1 TestExpectations file yet, but there's a section in the gtk-wk2 TestExpectations file that contains all the tests that pass on WK2 builders but fail on WK1. The intention of the gtk-wk1 TestExpectations is to contain expectations for such tests. > > We have a TestExpectations file for wk1 in gtk/. The exceptions we added in the wk2 file are there just because run-webkit-tests picks them both when run with "-2". True, but I'd argue that adding a wk1-specific TestExpectations file brings multiple benefits. When/If it gets populated with wk1-specific failures the differences in behavior between WebKit1 and WebKit2 layers will be easily observable. WebKit2 and WebKitTestRunner are considered to be a more appropriate guideline about specific testing behavior since they are implemented in a more platform-independent way than WebKit1 and DumpRenderTree. Furthermore WebKit2 is becoming the primary focus of the GTK port development. With all the expectation files in place, the main TestExpectations file would then contain mostly tests of which the problems originate in the WebCore layer.
Zan Dobersek
Comment 6 2012-12-20 02:48:35 PST
Created attachment 180309 [details] Patch Updated patch.
Zan Dobersek
Comment 7 2012-12-21 08:46:55 PST
Comment on attachment 180309 [details] Patch Clearing flags on attachment: 180309 Committed r138382: <http://trac.webkit.org/changeset/138382>
Zan Dobersek
Comment 8 2012-12-21 08:47:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.