Bug 97549

Summary: [EFL] unskip toDataURL tests
Product: WebKit Reporter: Jussi Kukkonen (jku) <jussi.kukkonen>
Component: WebKit EFLAssignee: Jussi Kukkonen (jku) <jussi.kukkonen>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jussi Kukkonen (jku) 2012-09-25 03:37:26 PDT
We should unskip these:
  fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html
  fast/canvas/toDataURL-supportedTypes.html

EFL port only supports "image/png" but that is the only one that is required by spec (and not testing that support is bad). I'll attach patch. I've also filed bug 97544 for supporting other image formats in future.
Comment 1 Jussi Kukkonen (jku) 2012-09-25 03:48:03 PDT
Created attachment 165574 [details]
Patch
Comment 2 Chris Dumez 2012-09-25 03:49:32 PDT
Comment on attachment 165574 [details]
Patch

LGTM.
Comment 3 Jussi Kukkonen (jku) 2012-09-25 03:49:36 PDT
Comment on attachment 165574 [details]
Patch

cq would be appreciated
Comment 4 WebKit Review Bot 2012-09-25 04:44:18 PDT
Comment on attachment 165574 [details]
Patch

Clearing flags on attachment: 165574

Committed r129488: <http://trac.webkit.org/changeset/129488>
Comment 5 WebKit Review Bot 2012-09-25 04:44:22 PDT
All reviewed patches have been landed.  Closing bug.