Bug 97525

Summary: Remove HAVE_SBRK since we never set use_sbrk to true
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: Web Template FrameworkAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, ddkilzer, ggaren, mifenton, psolanki, rwlbuis, thorton, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Pratik Solanki
Reported 2012-09-24 22:34:41 PDT
TCSystemAlloc.cpp has code inside HAVE(SBRK). However, we never really use sbrk() since the call to it is governed by the use_sbrk flag and that was set to false in 2005 in r10701 for bug 5243. We can move that code to be inside ifndef WTF_CHANGES.
Attachments
Patch (4.45 KB, patch)
2012-09-24 22:41 PDT, Pratik Solanki 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2012-09-24 22:34:54 PDT
<rdar://problem/12363601>
Pratik Solanki
Comment 2 2012-09-24 22:41:59 PDT
Created attachment 165522 [details] Patch
Geoffrey Garen
Comment 3 2012-09-24 23:05:41 PDT
Comment on attachment 165522 [details] Patch r=me
Pratik Solanki
Comment 4 2012-09-24 23:06:44 PDT
Thanks Geoff. I'll wait for the EWS bots to finish the builds before checking this in. Just in case...
Pratik Solanki
Comment 5 2012-09-25 13:40:30 PDT
Committed r129549: <http://trac.webkit.org/changeset/129549>
Note You need to log in before you can comment on or make changes to this bug.