Bug 97519

Summary: Remove JSObject::unwrappedGlobalObject(), JSObject::unwrappedObject()
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ossy, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 97529    
Bug Blocks:    
Attachments:
Description Flags
Fix ggaren: review+

Gavin Barraclough
Reported 2012-09-24 21:21:42 PDT
This will allow us to turn JSGlobalThis into a more generic proxy.
Attachments
Fix (8.67 KB, patch)
2012-09-24 21:30 PDT, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2012-09-24 21:30:35 PDT
Created attachment 165513 [details] Fix
Geoffrey Garen
Comment 2 2012-09-24 21:36:37 PDT
Comment on attachment 165513 [details] Fix r=me
Gavin Barraclough
Comment 3 2012-09-24 21:52:09 PDT
Fixed in r129456
Chris Dumez
Comment 4 2012-09-24 22:56:21 PDT
After this patch it seems, http/tests/security/xss-eval.html started failing on EFL port with the following diff: --- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/http/tests/security/xss-eval-expected.txt +++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/http/tests/security/xss-eval-actual.txt @@ -5,7 +5,7 @@ If the test passes, you'll see a pass message below. PASS: eval.call(frames[0], 'document') should be EvalError and is. -PASS: childEval.call(frames[0], 'document') should be EvalError and is. +FAIL: childEval.call(frames[0], 'document') should be EvalError but instead is [object HTMLDocument]. PASS: childEvalCaller('document') should be TypeError and is. -PASS: childLocalEvalCaller('document') should be EvalError and is. +FAIL: childLocalEvalCaller('document') should be EvalError but instead is [object HTMLDocument].
Chris Dumez
Comment 5 2012-09-24 22:58:04 PDT
(In reply to comment #4) > After this patch it seems, http/tests/security/xss-eval.html started failing on EFL port with the following diff: > --- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/http/tests/security/xss-eval-expected.txt > +++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/http/tests/security/xss-eval-actual.txt > @@ -5,7 +5,7 @@ > If the test passes, you'll see a pass message below. > > PASS: eval.call(frames[0], 'document') should be EvalError and is. > -PASS: childEval.call(frames[0], 'document') should be EvalError and is. > +FAIL: childEval.call(frames[0], 'document') should be EvalError but instead is [object HTMLDocument]. > PASS: childEvalCaller('document') should be TypeError and is. > -PASS: childLocalEvalCaller('document') should be EvalError and is. > +FAIL: childLocalEvalCaller('document') should be EvalError but instead is [object HTMLDocument]. Same on mac: http://build.webkit.org/builders/Apple%20Lion%20Release%20WK1%20%28Tests%29/builds/3958
Csaba Osztrogonác
Comment 7 2012-09-25 02:53:33 PDT
new bug report to track the regression: https://bugs.webkit.org/show_bug.cgi?id=97529
Note You need to log in before you can comment on or make changes to this bug.