Bug 97519

Summary:

Remove JSObject::unwrappedGlobalObject(), JSObject::unwrappedObject()

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, ossy, zarvai

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

97529

Bug Blocks:

Attachments:

Description	Flags
Fix	ggaren: review+

Description Gavin Barraclough 2012-09-24 21:21:42 PDT

This will allow us to turn JSGlobalThis into a more generic proxy.

Comment 1 Gavin Barraclough 2012-09-24 21:30:35 PDT

Created attachment 165513 [details]
Fix

Comment 2 Geoffrey Garen 2012-09-24 21:36:37 PDT

Comment on attachment 165513 [details]
Fix

r=me

Comment 3 Gavin Barraclough 2012-09-24 21:52:09 PDT

Fixed in r129456

Comment 4 Chris Dumez 2012-09-24 22:56:21 PDT

After this patch it seems, http/tests/security/xss-eval.html started failing on EFL port with the following diff:
--- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/http/tests/security/xss-eval-expected.txt
+++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/http/tests/security/xss-eval-actual.txt
@@ -5,7 +5,7 @@
 If the test passes, you'll see a pass message below.
 
 PASS: eval.call(frames[0], 'document') should be EvalError and is.
-PASS: childEval.call(frames[0], 'document') should be EvalError and is.
+FAIL: childEval.call(frames[0], 'document') should be EvalError but instead is [object HTMLDocument].
 PASS: childEvalCaller('document') should be TypeError and is.
-PASS: childLocalEvalCaller('document') should be EvalError and is.
+FAIL: childLocalEvalCaller('document') should be EvalError but instead is [object HTMLDocument].

Comment 5 Chris Dumez 2012-09-24 22:58:04 PDT

(In reply to comment #4)
> After this patch it seems, http/tests/security/xss-eval.html started failing on EFL port with the following diff:
> --- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/http/tests/security/xss-eval-expected.txt
> +++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/http/tests/security/xss-eval-actual.txt
> @@ -5,7 +5,7 @@
>  If the test passes, you'll see a pass message below.
> 
>  PASS: eval.call(frames[0], 'document') should be EvalError and is.
> -PASS: childEval.call(frames[0], 'document') should be EvalError and is.
> +FAIL: childEval.call(frames[0], 'document') should be EvalError but instead is [object HTMLDocument].
>  PASS: childEvalCaller('document') should be TypeError and is.
> -PASS: childLocalEvalCaller('document') should be EvalError and is.
> +FAIL: childLocalEvalCaller('document') should be EvalError but instead is [object HTMLDocument].

Same on mac:
http://build.webkit.org/builders/Apple%20Lion%20Release%20WK1%20%28Tests%29/builds/3958

Comment 6 Zoltan Arvai 2012-09-25 00:23:04 PDT

(In reply to comment #5)
> Same on mac:
> http://build.webkit.org/builders/Apple%20Lion%20Release%20WK1%20%28Tests%29/builds/3958

And same on Qt:
http://build.webkit.org/builders/Qt%20Linux%20Release/builds/52514

Comment 7 Csaba Osztrogonác 2012-09-25 02:53:33 PDT

new bug report to track the regression: https://bugs.webkit.org/show_bug.cgi?id=97529