Bug 97509

Summary:

[GTK][EFL] Remove cairo prefix from include statements

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, mrobinson, rakuco, webkit.review.bot

Priority:

Keywords:

Cairo, Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
first try	none

Laszlo Gombos

Reported 2012-09-24 18:29:30 PDT

It seems that most source files include cairo headers (e.g. cairo.h) assuming that the directory that contains the cairo header file are in the include path (which is indeed the case); however a few source files include cairo headers with a cairo prefix (e.g. cairo/cairo.h). This makes the build system unnecessary inconsistent, and in my case led to a build failure.

Attachments
first try (4.10 KB, patch) 2012-09-24 18:44 PDT, Laszlo Gombos	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2012-09-24 18:44:09 PDT

Created attachment 165496 [details] first try

Gyuyoung Kim

Comment 2 2012-09-24 20:23:44 PDT

Comment on attachment 165496 [details] first try Looks fine.

WebKit Review Bot

Comment 3 2012-09-24 20:55:07 PDT

Comment on attachment 165496 [details] first try Clearing flags on attachment: 165496 Committed r129450: <http://trac.webkit.org/changeset/129450>

WebKit Review Bot

Comment 4 2012-09-24 20:55:11 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.