Bug 97470

Summary: StylePropertySet: Use subclasses to manage varying object layouts.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, koivisto, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+, webkit.review.bot: commit-queue-
Hatch for splanding none

Andreas Kling
Reported 2012-09-24 11:33:17 PDT
We can avoid allocating StylePropertySet's Vector<CSSProperty> on the heap if we split the mutable/immutable behavior into subclasses.
Attachments
Patch (20.28 KB, patch)
2012-09-24 11:34 PDT, Andreas Kling 		koivisto: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Hatch for splanding (20.23 KB, patch)
2012-09-25 12:19 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2012-09-24 11:34:41 PDT
Created attachment 165416 [details] Patch
WebKit Review Bot
Comment 2 2012-09-24 11:38:03 PDT
Attachment 165416 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/StylePropertySet.h:52: The parameter name "cssParserMode" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2012-09-25 05:49:27 PDT
Comment on attachment 165416 [details] Patch Rejecting attachment 165416 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 1029 (offset -1 lines). Hunk #10 succeeded at 1042 (offset -1 lines). Hunk #11 FAILED at 1106. Hunk #12 succeeded at 1115 (offset -1 lines). Hunk #13 succeeded at 1128 (offset -1 lines). 1 out of 13 hunks FAILED -- saving rejects to file Source/WebCore/css/StylePropertySet.cpp.rej patching file Source/WebCore/css/StylePropertySet.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antti Koiv..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/13998000
Andreas Kling
Comment 4 2012-09-25 12:19:57 PDT
Created attachment 165654 [details] Hatch for splanding
WebKit Review Bot
Comment 5 2012-09-25 12:54:58 PDT
Comment on attachment 165654 [details] Hatch for splanding Clearing flags on attachment: 165654 Committed r129543: <http://trac.webkit.org/changeset/129543>
WebKit Review Bot
Comment 6 2012-09-25 12:55:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.