Bug 97455

Summary:

[BlackBerry] Reverting implementation for 407 error pages

Product:

WebKit

Reporter:

otcheung

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, feature-media-reviews, gyuyoung.kim, mifenton, rakuco, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
patch	none
patch (to rerun test)	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

otcheung

Reported 2012-09-24 08:05:34 PDT

We are reverting the behaviour for Bug 94138 due to changes in UX direction.

Attachments
Patch (3.89 KB, patch) 2012-09-24 08:08 PDT, otcheung	no flags	Details Formatted Diff Diff
Patch (5.86 KB, patch) 2012-09-24 12:04 PDT, otcheung	no flags	Details Formatted Diff Diff
Patch (6.68 KB, patch) 2012-09-24 12:53 PDT, otcheung	no flags	Details Formatted Diff Diff
Patch (32.32 KB, patch) 2012-09-24 14:19 PDT, otcheung	no flags	Details Formatted Diff Diff
patch (5.81 KB, patch) 2012-09-24 15:12 PDT, otcheung	no flags	Details Formatted Diff Diff
patch (to rerun test) (5.81 KB, patch) 2012-09-24 15:18 PDT, otcheung	no flags	Details Formatted Diff Diff
Patch (5.79 KB, patch) 2012-09-24 15:33 PDT, otcheung	no flags	Details Formatted Diff Diff
Patch (5.75 KB, patch) 2012-09-25 06:52 PDT, otcheung	no flags	Details Formatted Diff Diff
Patch (2.44 KB, patch) 2012-09-25 09:28 PDT, otcheung	no flags	Details Formatted Diff Diff
Patch (2.50 KB, patch) 2012-09-25 09:37 PDT, otcheung	no flags	Details Formatted Diff Diff
Patch (3.88 KB, patch) 2012-09-26 08:51 PDT, otcheung	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

otcheung

Comment 1 2012-09-24 08:08:39 PDT

Created attachment 165383 [details] Patch

otcheung

Comment 2 2012-09-24 12:04:47 PDT

Created attachment 165424 [details] Patch

otcheung

Comment 3 2012-09-24 12:53:24 PDT

Created attachment 165432 [details] Patch

Rob Buis

Comment 4 2012-09-24 12:58:00 PDT

Comment on attachment 165432 [details] Patch LGTM.

WebKit Review Bot

Comment 5 2012-09-24 13:21:17 PDT

Comment on attachment 165432 [details] Patch Clearing flags on attachment: 165432 Committed r129404: <http://trac.webkit.org/changeset/129404>

WebKit Review Bot

Comment 6 2012-09-24 13:21:21 PDT

All reviewed patches have been landed. Closing bug.

otcheung

Comment 7 2012-09-24 14:19:06 PDT

Reopening to attach new patch.

otcheung

Comment 8 2012-09-24 14:19:08 PDT

Created attachment 165446 [details] Patch

Rob Buis

Comment 9 2012-09-24 14:43:19 PDT

Comment on attachment 165446 [details] Patch LGTM.

WebKit Review Bot

Comment 10 2012-09-24 14:58:46 PDT

Comment on attachment 165446 [details] Patch Clearing flags on attachment: 165446 Committed r129419: <http://trac.webkit.org/changeset/129419>

WebKit Review Bot

Comment 11 2012-09-24 14:58:51 PDT

All reviewed patches have been landed. Closing bug.

otcheung

Comment 12 2012-09-24 15:12:22 PDT

Created attachment 165453 [details] patch

otcheung

Comment 13 2012-09-24 15:18:48 PDT

Created attachment 165454 [details] patch (to rerun test)

otcheung

Comment 14 2012-09-24 15:33:13 PDT

Reopening to attach new patch.

otcheung

Comment 15 2012-09-24 15:33:17 PDT

Created attachment 165455 [details] Patch

Rob Buis

Comment 16 2012-09-24 15:37:17 PDT

Comment on attachment 165455 [details] Patch Ok.

WebKit Review Bot

Comment 17 2012-09-24 16:11:59 PDT

Comment on attachment 165455 [details] Patch Rejecting attachment 165455 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 154708 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 51>At revision 154708. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13986846

Rob Buis

Comment 18 2012-09-24 16:39:34 PDT

(In reply to comment #17) > (From update of attachment 165455 [details]) > Rejecting attachment 165455 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > Kit/chromium/third_party/yasm/source/patched-yasm --revision 154708 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > 51>At revision 154708. > > ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > > ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > Updating webkit projects from gyp files... > > Full output: http://queues.webkit.org/results/13986846 Otto, it seems you need to fix your test line (OOPS!).

otcheung

Comment 19 2012-09-25 06:52:07 PDT

Created attachment 165603 [details] Patch

Rob Buis

Comment 20 2012-09-25 07:02:02 PDT

Comment on attachment 165603 [details] Patch Let's try!

WebKit Review Bot

Comment 21 2012-09-25 07:23:30 PDT

Comment on attachment 165603 [details] Patch Clearing flags on attachment: 165603 Committed r129504: <http://trac.webkit.org/changeset/129504>

WebKit Review Bot

Comment 22 2012-09-25 07:23:35 PDT

All reviewed patches have been landed. Closing bug.