Bug 97399

Summary: Allow setting a custom path to where the plug-in sandbox profiles are being kept
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Sam Weinig 2012-09-22 15:11:07 PDT 
Allow setting a custom path to where the plug-in sandbox profiles are being kept
Comment 1 Sam Weinig 2012-09-22 15:13:17 PDT 
Created attachment 165270 [details]
Patch
Comment 2 Anders Carlsson 2012-09-22 15:15:20 PDT 
Comment on attachment 165270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165270&action=review

> Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:56
> +NSString * const PlugInSandboxProfileDirectoryPathKey = @"PlugInSandboxProfileDirectoryPath";

I think the preference key should have a WebKit prefix.

> Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:140
> +    NSString* sandboxProfileDirectoryPath = [[NSUserDefaults standardUserDefaults] stringForKey:PlugInSandboxProfileDirectoryPathKey];
> +    if (sandboxProfileDirectoryPath)
> +        parameters.sandboxProfileDirectoryPath = String(sandboxProfileDirectoryPath);

Add a FIXME about disallowing this for app sandbox apps.
Comment 3 Sam Weinig 2012-09-22 15:18:12 PDT 
Committed r129309: <http://trac.webkit.org/changeset/129309>