Bug 97356

Summary: Add WebKit1 SPI for storage blocking preference
Product: WebKit Reporter: Vicki Pfau <jeffrey+webkit>
Component: WebKit APIAssignee: Vicki Pfau <jeffrey+webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch rebased against current ToT
none
Patch beidson: review+

Vicki Pfau
Reported 2012-09-21 13:26:14 PDT
The storage blocking preference only currently has an API in WebKit2. There should be one in WebKit1 as well.
Attachments
Patch (9.88 KB, patch)
2012-09-21 13:44 PDT, Vicki Pfau 		no flags
DetailsFormatted DiffDiff
Patch (9.24 KB, patch)
2012-09-21 14:12 PDT, Vicki Pfau 		no flags
DetailsFormatted DiffDiff
Patch rebased against current ToT (9.33 KB, patch)
2012-09-21 15:09 PDT, Vicki Pfau 		no flags
DetailsFormatted DiffDiff
Patch (10.27 KB, patch)
2012-09-24 16:01 PDT, Vicki Pfau 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Vicki Pfau
Comment 1 2012-09-21 13:44:51 PDT
Created attachment 165181 [details] Patch
Timothy Hatcher
Comment 2 2012-09-21 13:59:31 PDT
Comment on attachment 165181 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165181&action=review Otherwise this looks fine. > Source/WebKit/mac/ChangeLog:9 > + * WebView/WebPreferences.h: This needs added to WebPreferencesPrivate.h until it can be approved as API.
Vicki Pfau
Comment 3 2012-09-21 14:12:23 PDT
Created attachment 165191 [details] Patch
Vicki Pfau
Comment 4 2012-09-21 15:09:45 PDT
Created attachment 165203 [details] Patch rebased against current ToT
WebKit Review Bot
Comment 5 2012-09-21 15:57:47 PDT
Comment on attachment 165203 [details] Patch rebased against current ToT Attachment 165203 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13975519 New failing tests: WebFilterOperationsTest.saveAndRestore http/tests/security/cross-origin-local-storage-wk1.html
Adam Barth
Comment 6 2012-09-24 13:10:44 PDT
--- /src/abarth-webkit/Source/WebKit/chromium/webkit/Release/layout-test-results/http/tests/security/cross-origin-local-storage-wk1-expected.txt +++ /src/abarth-webkit/Source/WebKit/chromium/webkit/Release/layout-test-results/http/tests/security/cross-origin-local-storage-wk1-actual.txt @@ -1,3 +1,5 @@ +CONSOLE MESSAGE: Invalid name for preference: WebKitStorageBlockingPolicy +CONSOLE MESSAGE: Invalid name for preference: WebKitStorageBlockingPolicy This iframe should return a security error: @@ -8,7 +10,7 @@ -------- Frame: '<!--framePath //<!--frame0-->-->' -------- -SECURITY_ERR +No exception -------- Frame: '<!--framePath //<!--frame1-->-->'
Adam Barth
Comment 7 2012-09-24 13:11:15 PDT
Looks like you're missing some changes to Chromium's DumpRenderTree. Alternatively, you can use InternalsSettings.
Adam Barth
Comment 8 2012-09-24 13:12:32 PDT
Comment on attachment 165203 [details] Patch rebased against current ToT View in context: https://bugs.webkit.org/attachment.cgi?id=165203&action=review > LayoutTests/http/tests/security/cross-origin-local-storage-wk1.html:8 > + testRunner.overridePreference('WebKitStorageBlockingPolicy', 1); If you look in the DumpRenderTree implementations for various ports, you'll see how we handle overridePreference strings. It's pretty straightforward.
Vicki Pfau
Comment 9 2012-09-24 16:01:56 PDT
Created attachment 165459 [details] Patch
Sam Weinig
Comment 10 2012-09-25 00:52:04 PDT
Comment on attachment 165459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165459&action=review > Source/WebKit/mac/WebView/WebView.mm:1552 > + switch([preferences storageBlockingPolicy]) { You need a space after the word switch.
Brady Eidson
Comment 11 2012-09-25 13:42:43 PDT
Comment on attachment 165459 [details] Patch Nothing additional on top of Sam's comment.
Vicki Pfau
Comment 12 2012-09-25 16:01:15 PDT
Committed r129567: <http://trac.webkit.org/changeset/129567>
Vicki Pfau
Comment 13 2012-09-25 16:03:42 PDT
<rdar://problem/12372239>
Note You need to log in before you can comment on or make changes to this bug.