Bug 97341

Summary:

Web Inspector: support saving HAR with resources content

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aandrey, apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	vsevik: review+

Andrey Kosyakov

Reported 2012-09-21 08:16:06 PDT

Add "Save with content as HAR" option to network log's content menu. Remove context menu options for individual HAR entries, as these don't seem to make much sense.

Attachments
Patch (19.13 KB, patch) 2012-09-21 08:24 PDT, Andrey Kosyakov	no flags	Details Formatted Diff Diff
Patch (27.91 KB, patch) 2012-09-23 10:49 PDT, Andrey Kosyakov	no flags	Details Formatted Diff Diff
Patch (19.27 KB, patch) 2012-09-24 00:44 PDT, Andrey Kosyakov	vsevik: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2012-09-21 08:24:55 PDT

Created attachment 165136 [details] Patch

WebKit Review Bot

Comment 2 2012-09-21 10:11:09 PDT

Comment on attachment 165136 [details] Patch Attachment 165136 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13932667 New failing tests: http/tests/inspector/network/har-content.html

Build Bot

Comment 3 2012-09-21 10:46:12 PDT

Comment on attachment 165136 [details] Patch Attachment 165136 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13975422 New failing tests: http/tests/inspector/network/har-content.html

Andrey Kosyakov

Comment 4 2012-09-23 10:49:11 PDT

Created attachment 165289 [details] Patch

Andrey Kosyakov

Comment 5 2012-09-24 00:44:16 PDT

Created attachment 165323 [details] Patch

Vsevolod Vlasov

Comment 6 2012-09-24 01:55:38 PDT

Comment on attachment 165323 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165323&action=review > Source/WebCore/English.lproj/localizedStrings.js:134 > +localizedStrings["Save with content as HAR"] = "Save with content as HAR"; Save as HAR with content ?

Andrey Kosyakov

Comment 7 2012-09-24 02:40:32 PDT

Committed r129336: <http://trac.webkit.org/changeset/129336>

Andrey Adaikin

Comment 8 2012-09-24 03:09:06 PDT

FYI. $ compile-front-end Source/WebCore/inspector/front-end/HAREntry.js:419: WARNING - Function WebInspector.HARWriter.prototype._writeNextChunk: called with 1 argument(s). Function requires at least 2 argument(s) and no more than 2 argument(s). this._writeNextChunk(this._stream); ^ Source/WebCore/inspector/front-end/HAREntry.js:436: WARNING - actual parameter 2 of WebInspector.OutputStream.write does not match formal parameter found : function ((WebInspector.OutputStream|null), string): undefined required: (function ((WebInspector.OutputStream|null)): ?|undefined) stream.write(text, this._writeNextChunk.bind(this)); ^

Note You need to log in before you can comment on or make changes to this bug.