Bug 97332

Summary: Web Inspector: Open resource dialog has too many false positive matches.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, eustas.bug, joepeck, johnjbarton, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Vsevolod Vlasov
Reported 2012-09-21 06:33:01 PDT
Patch to follow.
Attachments
Patch (9.58 KB, patch)
2012-09-21 06:48 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (8.24 KB, patch)
2012-09-24 02:21 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (8.83 KB, patch)
2012-09-24 04:32 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-09-21 06:48:05 PDT
Created attachment 165128 [details] Patch
Vsevolod Vlasov
Comment 2 2012-09-24 02:21:43 PDT
Created attachment 165336 [details] Patch
Vsevolod Vlasov
Comment 3 2012-09-24 04:32:42 PDT
Created attachment 165355 [details] Patch
WebKit Review Bot
Comment 4 2012-09-24 06:17:04 PDT
Comment on attachment 165355 [details] Patch Clearing flags on attachment: 165355 Committed r129355: <http://trac.webkit.org/changeset/129355>
WebKit Review Bot
Comment 5 2012-09-24 06:17:08 PDT
All reviewed patches have been landed. Closing bug.
Zoltan Arvai
Comment 6 2012-09-24 07:52:11 PDT
After the patch inspector/filtered-item-selection-dialog-filtering.html fails on Qt. Can you check the result, please? http://build.webkit.org/results/Qt%20Linux%20Release/r129359%20(52464)/inspector/filtered-item-selection-dialog-filtering-pretty-diff.html
johnjbarton
Comment 7 2012-09-26 14:15:58 PDT
After this change I can no longer find all of the .css files by entering ".css". If I type "Source", JavaScriptSourceFrame.js no longer appears in the list.
Vsevolod Vlasov
Comment 8 2012-09-27 02:45:36 PDT
(In reply to comment #7) > After this change I can no longer find all of the .css files by entering ".css". > > If I type "Source", JavaScriptSourceFrame.js no longer appears in the list. You can use *.css or *Source as a workaround while we are figuring out the best way to implement this.
Vsevolod Vlasov
Comment 9 2012-09-27 02:48:15 PDT
(In reply to comment #6) > After the patch inspector/filtered-item-selection-dialog-filtering.html fails on Qt. Can you check the result, please? > > http://build.webkit.org/results/Qt%20Linux%20Release/r129359%20(52464)/inspector/filtered-item-selection-dialog-filtering-pretty-diff.html Looks like it passes now.
Note You need to log in before you can comment on or make changes to this bug.