Bug 97286 – Chromium mac cannot display AppleColorEmoji

• Component: Platform
• Status: RESOLVED FIXED

[Kenichi Ishibashi]

See http://crbug.com/62435

We need to ask Skia to use CTFontDrawGlyphs(). It will take time, so I'd like to disable AppleColorEmoji for now so that fallback fonts can be selected.

[Kenichi Ishibashi]

Created attachment 165038 [details]
Patch

[Kenichi Ishibashi]

Kent-san,

What do you think about disabling AppleColorEmoji now?

[Kent Tamura]

Comment on attachment 165038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165038&action=review

> Source/WebCore/platform/graphics/mac/FontCacheMac.mm:122
> +#if PLATFORM(CHROMIUM) && OS(DARWIN)
> +    // Chromium can't render AppleColorEmoji.
> +    if ([[substituteFont familyName] isEqual:@"Apple Color Emoji"])
> +        return 0;
> +#endif

nit: I think OS(DARWIN) is not needed.

FYI:
Using PLATFORM() macro is not preferable in general.
Ideally, we had better have WTF_USE_NO_APPLE_COLOR_EMOJI flag, and enable it for Chromium in WebCore/config.h.

Using PLATFORM() is acceptable in this case because it's temporarily.

[Kenichi Ishibashi]

Created attachment 165041 [details]
Patch for landing

[Kenichi Ishibashi]

Comment on attachment 165038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165038&action=review

>> Source/WebCore/platform/graphics/mac/FontCacheMac.mm:122
>> +#endif
> 
> nit: I think OS(DARWIN) is not needed.
> 
> FYI:
> Using PLATFORM() macro is not preferable in general.
> Ideally, we had better have WTF_USE_NO_APPLE_COLOR_EMOJI flag, and enable it for Chromium in WebCore/config.h.
> 
> Using PLATFORM() is acceptable in this case because it's temporarily.

Removed OS(DARWIN).

Thank you for the heads-up. I'll keep in mind it!

[WebKit Review Bot]

Comment on attachment 165041 [details]
Patch for landing

Clearing flags on attachment: 165041

Committed r129190: <http://trac.webkit.org/changeset/129190>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.