Bug 97283
| Summary: | consider using something other than "[" and "]" for delimiters in the new TestExpectations syntax | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | apavlov, ap, fpizlo, jberlin, noel.gordon, ojan, ossy, rniwa, simon.fraser, slewis, tony |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Dirk Pranke
Much as I hate to reopen this kettle of fish, I'm starting to think we should use something other than "[" and "]" as the delimiters in the new syntax. When people read the documentation, they've had that notation beaten into them by EBNF to think that that indicates that they are optional. Given that the enclosed sections are optional, this is pretty confusing.
i.e.,
webkit.org/b/12345 [ Debug ] foo.html [ Failure ]
it's easy to see that in docs and think that you don't need to type in the "[" and "]" on the line.
Perhaps we should switch to something else? On the other hand, people will get the idea pretty quickly so perhaps it's not worth changing?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
I'm fine with using () or {}. Avoid <> to be easily mixed with HTML. But I don't think people will mistake [] as BNF notation.
Dirk Pranke
(In reply to comment #1)
> I don't think people will mistake [] as BNF notation.
People already have :)
Dirk Pranke
Given that no one has chimed in on this besides rniwa, who seemed to think that [] was fine, I'm going to let this dog sleep.