Summary: | Kerning never occurs between a space and the following glyph | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||
Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
Status: | REOPENED --- | ||||||
Severity: | Normal | CC: | mmaxfield, simon.fraser, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
mitz
2012-09-20 16:05:27 PDT
Created attachment 165005 [details]
Maintain the advances of space characters
Fixed in <http://trac.webkit.org/r129176>. This broke a test: http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r129181%20(3827)/results.html (In reply to comment #3) > This broke a test: > http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r129181%20(3827)/results.html Thanks for noticing this. The original change included updated results for this test for current OS X, but failed to update the Lion results. I have since updated them. This changed led to an inconsistency between the measurements in line breaking and the ones in RenderText::computePreferredLogicalWidths, which measures spaces separately from their surroundings. I am going to revert it for now. Reverted in <http://trac.webkit.org/r129389>. Comment on attachment 165005 [details] Maintain the advances of space characters Cleared Tim Horton's review+ from obsolete attachment 165005 [details] so that this bug does not appear in http://webkit.org/pending-commit. |