Bug 97266 – Deleting across multiple paragraphs can change the style of surrounding text

• Component: HTML Editing
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Deleting text from multiple paragraphs can alter the style of surrounding text if all text involved have the same style from css rules and have inline style declaration.

[Ryosuke Niwa]

Created attachment 164995 [details]
Demo

[Jelte Liebrand]

This defect impacts our Document Viewer for Chrome.  Ideally the spans that get created during the deletion of a selection (to merge the text) would inherit the className of the original spans.  However, as this is potentially tricky, at the very least it would be great if the span would get the same styling applied to it such that the text looks OK.

[Ojan Vafai]

Filed related bug 97345 for maintaining attributes on inlines.

[Ryosuke Niwa]

Created attachment 167356 [details]
Fixes the bug

[Levi Weintraub]

Comment on attachment 167356 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=167356&action=review

Looks good. We talked in person.

> Source/WebCore/editing/EditingStyle.cpp:1027
> -        if (node->isStyledElement()) {
> +        if (node->isStyledElement() && !isMailBlockquote(node)) {

I understand this change, but wish there were explanation in the changelog.

> LayoutTests/ChangeLog:8
> +        Added a regerssion test and rebaselined tests.

like smfr said ;)

[Ryosuke Niwa]

Committed r130532: <http://trac.webkit.org/changeset/130532>