Bug 97249

Summary:

Web Inspector: [REGRESSION] Cmd-Shift-C doesn't enable element inspection mode when inspector hidden

Product:

WebKit

Reporter:

Paul Irish <paulirish>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+

Paul Irish

Reported 2012-09-20 12:19:32 PDT

I believe we have a slight regression here, cmd-shift-c does start element inspection when inspector is visible, however when it's still hidden it only opens the inspector. this is different behavior than what cmd-shift-c did previously.

Attachments
Patch (3.02 KB, patch) 2012-09-21 03:28 PDT, Alexander Pavlov (apavlov)	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2012-09-21 03:10:16 PDT

The code was broken in http://trac.webkit.org/changeset/125871

Alexander Pavlov (apavlov)

Comment 2 2012-09-21 03:28:18 PDT

Created attachment 165108 [details] Patch

Alexander Pavlov (apavlov)

Comment 3 2012-09-24 04:55:30 PDT

Committed r129348: <http://trac.webkit.org/changeset/129348>

Note You need to log in before you can comment on or make changes to this bug.