Bug 97242

Summary: Unexpected reftest passes are only reported when pixel testing is enabled
Product: WebKit Reporter: Zan Dobersek <zan>
Component: Tools / TestsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dpranke: review+

Zan Dobersek
Reported 2012-09-20 11:53:26 PDT
TSIA. A follow-up to bug #97112.
Attachments
Patch (5.78 KB, patch)
2012-09-20 12:05 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (6.77 KB, patch)
2012-09-21 00:18 PDT, Zan Dobersek 		dpranke: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-09-20 12:05:23 PDT
Created attachment 164961 [details] Patch
Dirk Pranke
Comment 2 2012-09-20 14:07:40 PDT
Comment on attachment 164961 [details] Patch the change is basically fine, but can you make is_reftest a field on the TestResult object rather than passing a separate parameter across?
Zan Dobersek
Comment 3 2012-09-21 00:18:44 PDT
Created attachment 165062 [details] Patch
Dirk Pranke
Comment 4 2012-09-21 11:20:17 PDT
Comment on attachment 165062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165062&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:306 > + return TestResult(self._test_name, test_result.failures, total_test_time + test_result.test_run_time, test_result.has_stderr, True) nit: I'd say is_reftest=True here.
Zan Dobersek
Comment 5 2012-09-22 01:10:11 PDT
Committed r129303: <http://trac.webkit.org/changeset/129303>
Note You need to log in before you can comment on or make changes to this bug.