Summary: | [EFL] Change the log macro names to be more consistent with EINA LOG | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jinwoo Song <jinwoo7.song> | ||||||
Component: | WebKit EFL | Assignee: | Jinwoo Song <jinwoo7.song> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Jinwoo Song
2012-09-19 18:22:48 PDT
Created attachment 164824 [details]
patch
Comment on attachment 164824 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=164824&action=review It would be good if you add a link we discuss about this on webkit-efl mailing list. > Source/WebKit/efl/ewk/ewk_private.h:47 > #define CRITICAL(...) EINA_LOG_DOM_CRIT(_ewk_log_dom, __VA_ARGS__) Why not change CRITICAL with CRIT ? Please refer the discussions in mailing list, http://lists.webkit.org/pipermail/webkit-efl/2012-September/000282.html (In reply to comment #2) > (From update of attachment 164824 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164824&action=review > > It would be good if you add a link we discuss about this on webkit-efl mailing list. > > > Source/WebKit/efl/ewk/ewk_private.h:47 > > #define CRITICAL(...) EINA_LOG_DOM_CRIT(_ewk_log_dom, __VA_ARGS__) > > Why not change CRITICAL with CRIT ? Actually, I think 'CRITICAL' is more clear and readable than 'CRIT'. Although the name is not exactly same with that of EINA LOG, 'CRIT' itself does not give intuitive meaning to us. But if I'd like to vote the prefer one in the mailing list. Comment on attachment 164824 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=164824&action=review > Source/WebKit/efl/ewk/ewk_private.h:51 > #define DBG(...) EINA_LOG_DOM_DBG(_ewk_log_dom, __VA_ARGS__) maybe DEBUG would also be better Comment on attachment 164824 [details] patch Rejecting attachment 164824 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /WebKit/efl/ewk/ewk_view_private.h patching file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/UIProcess/API/efl/ewk_main.cpp patching file Source/WebKit2/UIProcess/API/efl/ewk_private.h patching file Source/WebKit2/UIProcess/API/efl/ewk_view.cpp Hunk #1 succeeded at 1646 (offset 3 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/13948104 Created attachment 164853 [details]
rebased patch
Comment on attachment 164853 [details] rebased patch Clearing flags on attachment: 164853 Committed r129101: <http://trac.webkit.org/changeset/129101> All reviewed patches have been landed. Closing bug. |