Bug 97113

Summary: Web Inspector: Prepare UISourceCode to transformation into File.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Vsevolod Vlasov
Reported 2012-09-19 08:28:41 PDT
I'd like to transform UISourceCode to domain/debugger agnostic File. I want to move all domain specific logic to editor, breakpoint manager and debugger model and remove JavaScriptSource, StyleSource, SASSSource and SnippetJavaScriptSource classes. In this patch I am removing all methods and fields from this classes except for the modification bindings.
Attachments
Patch (39.74 KB, patch)
2012-09-19 09:07 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-09-19 09:07:05 PDT
Created attachment 164745 [details] Patch
Pavel Feldman
Comment 2 2012-09-20 04:19:58 PDT
Comment on attachment 164745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164745&action=review > Source/WebCore/inspector/front-end/BreakpointManager.js:64 > +WebInspector.BreakpointManager.isDivergedFromVM = function(uiSourceCode) hasDiverged ?
Vsevolod Vlasov
Comment 3 2012-09-28 01:44:27 PDT
Committed r129862: <http://trac.webkit.org/changeset/129862>
Note You need to log in before you can comment on or make changes to this bug.