Summary: | [Chromium] Improve glyph positioning of HarfBuzzShaper | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenichi Ishibashi <bashi> | ||||||||
Component: | Platform | Assignee: | Kenichi Ishibashi <bashi> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | tony, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Kenichi Ishibashi
2012-09-19 03:08:57 PDT
Created attachment 164705 [details]
Patch
Hi Tony, Could you take a look? Comment on attachment 164705 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164705&action=review FWIW, if you uploaded before and after png results for the tests that change as a separate attachment to the bug, it would help me understand the change. > Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:319 > + // HarfBuzz returns the shaping result in visual order. We need not to flip for RTL Nit: Missing period at the end of the sentence. Created attachment 164786 [details]
Patch for landing
(In reply to comment #3) > (From update of attachment 164705 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164705&action=review > > FWIW, if you uploaded before and after png results for the tests that change as a separate attachment to the bug, it would help me understand the change. > I should have done so. I'll do it next time. > > Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:319 > > + // HarfBuzz returns the shaping result in visual order. We need not to flip for RTL > > Nit: Missing period at the end of the sentence. Done. Comment on attachment 164786 [details] Patch for landing Rejecting attachment 164786 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: kitpy/layout_tests/models/test_expectations_unittest.py Failed to merge in the changes. Patch failed at 0001 implement first part of support for the new TestExpectations syntax When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13905607 Created attachment 164791 [details]
Patch for landing
Comment on attachment 164791 [details] Patch for landing Clearing flags on attachment: 164791 Committed r129074: <http://trac.webkit.org/changeset/129074> All reviewed patches have been landed. Closing bug. |