Bug 97080

Summary:

DFG should not emit PutByVal hole case unless it has to

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
work in progress	webkit-ews: commit-queue-
the patch	ggaren: review+

Filip Pizlo

Reported 2012-09-19 00:57:30 PDT

This is useful for two reasons: 1) If the hole case is never hit then we should just emit less code. The hole check becomes a speculation check instead of a jump over some slow path code. 2) It gives us some ability to bloat the hole case code if we need to, for example if it becomes useful for contiguous array inference.

Attachments
work in progress (24.32 KB, patch) 2012-09-19 01:01 PDT, Filip Pizlo	webkit-ews: commit-queue-	Details Formatted Diff Diff
the patch (27.84 KB, patch) 2012-09-19 02:44 PDT, Filip Pizlo	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.