Bug 97069

Summary: [Chromium] HarfBuzzShaper should take into account combining characters
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: PlatformAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix typo none

Kenichi Ishibashi
Reported 2012-09-18 22:32:50 PDT
Some fonts don't have individual glyphs for marks, but have composite glyphs. For example, A font can have a glyph for U+00e9 (e with acute) even if it doesn't have a glyph for U+0301(combining acute accent). We should take into account this fast when we divide a text run into HarfBuzzRuns. If the font also doesn't have composite glyphs, we should try fallback fonts for mark characters.
Attachments
Patch (5.45 KB, patch)
2012-09-18 22:37 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Fix typo (5.46 KB, patch)
2012-09-18 22:41 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2012-09-18 22:37:54 PDT
Created attachment 164660 [details] Patch
Kenichi Ishibashi
Comment 2 2012-09-18 22:41:47 PDT
Created attachment 164661 [details] Fix typo
Kenichi Ishibashi
Comment 3 2012-09-18 22:42:15 PDT
Hi tony, Could you take a look?
Tony Chang
Comment 4 2012-09-19 10:18:26 PDT
Comment on attachment 164661 [details] Fix typo OK
Kenichi Ishibashi
Comment 5 2012-09-19 15:21:23 PDT
Comment on attachment 164661 [details] Fix typo Thank you!
WebKit Review Bot
Comment 6 2012-09-19 15:28:44 PDT
Comment on attachment 164661 [details] Fix typo Clearing flags on attachment: 164661 Committed r129050: <http://trac.webkit.org/changeset/129050>
WebKit Review Bot
Comment 7 2012-09-19 15:28:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.