Bug 97066

Summary:

[V8] Move WorkerContextExecutionProxy::initIsolate() to WorkerScriptController

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abarth, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

97057

Attachments:

Description	Flags
Patch	abarth: review-

Kentaro Hara

Reported 2012-09-18 20:59:20 PDT

To kill WorkerContextExecutionProxy, we can move WorkerContextExecutionProxy::initIsolate() to WorkerScriptController.

Attachments
Patch (10.10 KB, patch) 2012-09-18 21:03 PDT, Kentaro Hara	abarth: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-09-18 21:03:21 PDT

Created attachment 164655 [details] Patch

Adam Barth

Comment 2 2012-09-19 11:34:23 PDT

Comment on attachment 164655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164655&action=review > Source/WebCore/bindings/v8/V8Binding.cpp:362 > + int memoryUsageMB = MemoryUsageSupport::actualMemoryUsageMB(); Is this function safe to call on a worker thread? I guess we're just going to CRASH() a couple lines later, but it seems like we should make sure the threading is ok anyway. > Source/WebCore/bindings/v8/WorkerScriptController.cpp:88 > +void WorkerScriptController::initIsolate() This function looks very similar to initializeV8IfNeeded. Should we move initializeV8IfNeeded and friends into V8Initializer.(cpp|h) and share more code?

Kentaro Hara

Comment 3 2012-09-19 18:06:23 PDT

(In reply to comment #2) > This function looks very similar to initializeV8IfNeeded. Should we move initializeV8IfNeeded and friends into V8Initializer.(cpp|h) and share more code? Sounds better. I'll do it. Thanks.

Note You need to log in before you can comment on or make changes to this bug.