Bug 96998

Summary: [GTK] run-webkit-tests unable to find TestExpectations for WK2
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, pnormand, rniwa, svillar, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sergio Villar Senin
Reported 2012-09-18 04:08:44 PDT
[GTK] run-webkit-tests unable to find TestExpectations for WK2
Attachments
Patch (1.61 KB, patch)
2012-09-18 04:12 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2012-09-18 04:12:15 PDT
Created attachment 164530 [details] Patch
Sergio Villar Senin
Comment 2 2012-09-18 04:32:39 PDT
Comment on attachment 164530 [details] Patch Clearing flags on attachment: 164530 Committed r128874: <http://trac.webkit.org/changeset/128874>
Sergio Villar Senin
Comment 3 2012-09-18 04:32:43 PDT
All reviewed patches have been landed. Closing bug.
Dirk Pranke
Comment 4 2012-09-18 10:09:29 PDT
Comment on attachment 164530 [details] Patch We should probably just make this the default implementation in base.py; it looks like no one is using that implementation anymore, and this clones the implementation in apple.py. Qt, Chromium, and Efl all use different logic.
Sergio Villar Senin
Comment 5 2012-09-18 11:07:01 PDT
(In reply to comment #4) > (From update of attachment 164530 [details]) > We should probably just make this the default implementation in base.py; it looks like no one is using that implementation anymore, and this clones the implementation in apple.py. Qt, Chromium, and Efl all use different logic. Good point Dirk, I didn't review the other ports implementation when dealing with this issue. I can open a new bug moving the port specific implementations to the base class.
Note You need to log in before you can comment on or make changes to this bug.