Summary: | [Qt][WK2] Focus out is not handled properly | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Heikki Paajanen <hepaajan> | ||||||||||
Component: | New Bugs | Assignee: | Michael Brüning <michael.bruning> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abecsi, allan.jensen, cmarcelo, menard, michael.bruning, pnormand, webkit.review.bot, zoltan | ||||||||||
Priority: | P3 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Heikki Paajanen
2012-09-18 03:56:46 PDT
I'll check this. Created attachment 165137 [details]
Patch
The solution here might be a bit "hacky", but it seems to be the least complicated way. Better suggestions are welcome as always :) Would it possible to set the focus value on the UIProcess side as soon as the event is send to the WebProcess? Focus out shouldn't be an event the WebProcess can block anyway. (In reply to comment #4) > Would it possible to set the focus value on the UIProcess side as soon as the event is send to the WebProcess? Focus out shouldn't be an event the WebProcess can block anyway. It's not really the WebProcess "blocking" the focus, it's the UI process feeding it with the wrong value and hence the FocusController doesn't set the focus on the text element correctly. Anyway, after digging through the focus event handling etc, I have found that virtual void QQuickItem::itemChange(ItemChange change, const ItemChangeData &value); is the right method to override here as also e.g. the QQuickTextInput uses that for deciding about lost focus (gaining focus seems to work...). Updated patch coming soon... Created attachment 165379 [details]
Patch
As already correctly noted by Simon on irc, the call to QQuickItem::itemChange() will be changed to QQuickFlickable::itemChange(). Created attachment 165559 [details]
Patch
Created attachment 165592 [details]
Patch
Comment on attachment 165592 [details] Patch Clearing flags on attachment: 165592 Committed r129496: <http://trac.webkit.org/changeset/129496> All reviewed patches have been landed. Closing bug. |