|Summary:||[GTK] Build is broken without option --enable-unstable-features|
|Product:||WebKit||Reporter:||Carlos Garcia Campos <cgarcia>|
|Component:||WebKitGTK||Assignee:||Zan Dobersek <zan>|
|Severity:||Normal||CC:||mrobinson, pnormand, zan|
|Version:||528+ (Nightly build)|
Description Carlos Garcia Campos 2012-09-18 03:38:43 PDT
It seems that for some reason -DENABLE_VIDEO=1 is not passed to WebCore CPP flags, even though it's enabled in configure. Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:84:5: error: ‘GStreamerGWorld’ in namespace ‘WebCore’ does not name a type
Comment 1 Philippe Normand 2012-09-18 03:41:22 PDT
This happens with non-build-webkit builds
Comment 2 Carlos Garcia Campos 2012-09-18 04:41:10 PDT
(In reply to comment #1) > This happens with non-build-webkit builds Because build-webkit always uses --enable-unstable-features
Comment 3 Zan Dobersek 2012-09-18 05:19:26 PDT
I'll see into it.
Comment 4 jaybhaskar 2012-09-18 06:40:22 PDT
Created attachment 164546 [details] this is a simple patch which passes ENABLE_VIDEO=1 in webore_cpp flags Build will pass without --enable-unstable-features by this one line changes in Source/WebCore/GNUmakefile.am
Comment 6 Zan Dobersek 2012-09-18 09:15:43 PDT
(In reply to comment #5) > Created an attachment (id=164574) [details] > Patch The problem was that with unstable features disabled, ENABLE_VIDEO_TRACK was located in the feature_defines_unstable variable. The ENABLE_VIDEO define was then erroneously found in feature_defines_unstable but the pattern was not possible to obtain from it, so ENABLE_VIDEO feature define was not present in feature_defines nor webcore_cppflags. The fix is simple, when searching for the feature define in overriding variables, we should search for the bare define followed by the equal sign, for instance ENABLE_VIDEO= (which will not match in ENABLE_VIDEO_TRACK anymore).
Comment 7 Zan Dobersek 2012-09-18 10:42:33 PDT
Comment on attachment 164574 [details] Patch Clearing flags on attachment: 164574 Committed r128905: <http://trac.webkit.org/changeset/128905>
Comment 8 Zan Dobersek 2012-09-18 10:42:38 PDT
All reviewed patches have been landed. Closing bug.