Summary: | [GTK] Build is broken without option --enable-unstable-features | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKitGTK | Assignee: | Zan Dobersek <zan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mrobinson, pnormand, zan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2012-09-18 03:38:43 PDT
This happens with non-build-webkit builds (In reply to comment #1) > This happens with non-build-webkit builds Because build-webkit always uses --enable-unstable-features I'll see into it. Created attachment 164546 [details]
this is a simple patch which passes ENABLE_VIDEO=1 in webore_cpp flags
Build will pass without --enable-unstable-features by this one line changes in Source/WebCore/GNUmakefile.am
Created attachment 164574 [details]
Patch
(In reply to comment #5) > Created an attachment (id=164574) [details] > Patch The problem was that with unstable features disabled, ENABLE_VIDEO_TRACK was located in the feature_defines_unstable variable. The ENABLE_VIDEO define was then erroneously found in feature_defines_unstable but the pattern was not possible to obtain from it, so ENABLE_VIDEO feature define was not present in feature_defines nor webcore_cppflags. The fix is simple, when searching for the feature define in overriding variables, we should search for the bare define followed by the equal sign, for instance ENABLE_VIDEO= (which will not match in ENABLE_VIDEO_TRACK anymore). Comment on attachment 164574 [details] Patch Clearing flags on attachment: 164574 Committed r128905: <http://trac.webkit.org/changeset/128905> All reviewed patches have been landed. Closing bug. Comment on attachment 164546 [details]
this is a simple patch which passes ENABLE_VIDEO=1 in webore_cpp flags
Zan fixed this bug. Pulling out obsolete patch out of review queue
|