Bug 96972

Summary:

[Win] Null check timing function received from CoreAnimation when calling CACFAnimationGetTimingFunction.

Product:

WebKit

Reporter:

Roger Fong <roger_fong>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser, thorton

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
patch	none
patch	thorton: review+

Description Roger Fong 2012-09-17 19:44:37 PDT

When paused, some CSS animations cause CoreAnimation to pass back a null timing function when calling CACFAnimationGetTimingFunction.
This patch fixes this simply by ensuring that if the output of this method is null, it does not get passed into CACFAnimationSetTimingFunction via the PlatformCAAnimation::copyTimingFunctionFrom method. This is a workaround. There is most likely a more appropriate fix in CoreAnimation to deal with the null return.

Comment 1 Roger Fong 2012-09-17 19:59:16 PDT

Created attachment 164482 [details]
patch

Comment 2 Roger Fong 2012-09-17 20:05:47 PDT

Note that the CACFAnimationSetTimingFunction will always crash when null is passed in for the timingFunc parameter.

Comment 3 Roger Fong 2012-09-17 20:07:34 PDT

Created attachment 164485 [details]
patch

Comment 4 Tim Horton 2012-09-17 20:17:54 PDT

<rdar://problem/12088487>

Comment 5 Roger Fong 2012-09-17 20:20:09 PDT

http://trac.webkit.org/changeset/128845

Comment 6 Tim Horton 2012-09-17 20:22:27 PDT

You seem to have killed the "Reviewed by" part of the review line :\

Comment 7 Roger Fong 2012-09-17 20:24:56 PDT

oops, i will fix