Bug 96972

Summary: [Win] Null check timing function received from CoreAnimation when calling CACFAnimationGetTimingFunction.
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch
none
patch thorton: review+

Roger Fong
Reported 2012-09-17 19:44:37 PDT
When paused, some CSS animations cause CoreAnimation to pass back a null timing function when calling CACFAnimationGetTimingFunction. This patch fixes this simply by ensuring that if the output of this method is null, it does not get passed into CACFAnimationSetTimingFunction via the PlatformCAAnimation::copyTimingFunctionFrom method. This is a workaround. There is most likely a more appropriate fix in CoreAnimation to deal with the null return.
Attachments
patch (1.84 KB, patch)
2012-09-17 19:59 PDT, Roger Fong 		no flags
DetailsFormatted DiffDiff
patch (1.93 KB, patch)
2012-09-17 20:07 PDT, Roger Fong 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2012-09-17 19:59:16 PDT
Created attachment 164482 [details] patch
Roger Fong
Comment 2 2012-09-17 20:05:47 PDT
Note that the CACFAnimationSetTimingFunction will always crash when null is passed in for the timingFunc parameter.
Roger Fong
Comment 3 2012-09-17 20:07:34 PDT
Created attachment 164485 [details] patch
Tim Horton
Comment 4 2012-09-17 20:17:54 PDT
<rdar://problem/12088487>
Roger Fong
Comment 5 2012-09-17 20:20:09 PDT
http://trac.webkit.org/changeset/128845
Tim Horton
Comment 6 2012-09-17 20:22:27 PDT
You seem to have killed the "Reviewed by" part of the review line :\
Roger Fong
Comment 7 2012-09-17 20:24:56 PDT
oops, i will fix
Note You need to log in before you can comment on or make changes to this bug.