Bug 96915

Summary:

[EFL] Several key codes are not mapped with evas key name.

Product:

WebKit

Reporter:

Ryuan Choi <ryuan.choi>

Component:

WebKit EFL

Assignee:

Ryuan Choi <ryuan.choi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Ryuan Choi 2012-09-17 06:29:45 PDT

Several key codes are not mapped with evas key name such as KP_0

Patch will be added.

Comment 1 Ryuan Choi 2012-09-17 06:45:53 PDT

Created attachment 164386 [details]
Patch

Comment 2 Raphael Kubo da Costa (:rakuco) 2012-09-17 06:57:45 PDT

Comment on attachment 164386 [details]
Patch

Can any test be unskipped?

Comment 3 Ryuan Choi 2012-09-17 08:44:53 PDT

(In reply to comment #2)
> (From update of attachment 164386 [details])
> Can any test be unskipped?

No, the results were same with/without this.

Comment 4 Gyuyoung Kim 2012-09-17 17:35:13 PDT

Comment on attachment 164386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164386&action=review

> Source/WebCore/platform/efl/EflKeyboardUtilities.cpp:210
>  

Add a comment for keymap added by this loop.

Comment 5 Ryuan Choi 2012-09-17 18:22:48 PDT

Committed r128835: <http://trac.webkit.org/changeset/128835>