Bug 96907

Summary: [Qt]REGRESSION(r128699): It made 2 fast/js/dfg tests assert
Product: WebKit Reporter: János Badics <jbadics>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: fpizlo, oliver, ossy, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79668, 96872    
Attachments:
Description Flags
Patch none

Description János Badics 2012-09-17 04:42:54 PDT
Modifications in r128699 made fast/js/dfg-inline-arguments-use-from-all-the-places-broken.html and fast/js/dfg-inline-arguments-use-from-all-the-places.html assert. These asserts can be found at
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Debug/r128699%20(25176)/fast/js/dfg-inline-arguments-use-from-all-the-places-broken-crash-log.txt
and
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Debug/r128699%20(25176)/fast/js/dfg-inline-arguments-use-from-all-the-places-crash-log.txt

You can see the original bug at:
https://bugs.webkit.org/show_bug.cgi?id=96872

These tests will be skipped until the proper fix.
Comment 1 Csaba Osztrogonác 2012-09-17 09:11:59 PDT
GDB backtrace - fast/js/dfg-inline-arguments-use-from-all-the-places-broken.html
--------------------------------------------------------------------------------
$ gdb WebKitBuild/Debug/bin/WebKitTestRunner
GNU gdb (GDB) 7.0.1-debian
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /home/oszi/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner...done.
(gdb) run LayoutTests/fast/js/dfg-inline-arguments-use-from-all-the-places-broken.html
Starting program: /home/oszi/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner LayoutTests/fast/js/dfg-inline-arguments-use-from-all-the-places-broken.html
[Thread debugging using libthread_db enabled]
[New Thread 0x7fffa62a0700 (LWP 31187)]
[New Thread 0x7fffa609f700 (LWP 31188)]
[New Thread 0x7fffa5e9e700 (LWP 31189)]
[New Thread 0x7ffff7ff8700 (LWP 31190)]
[New Thread 0x7fffa5a9b700 (LWP 31191)]
[New Thread 0x7fffa589a700 (LWP 31193)]
ASSERTION FAILED: modeAlreadyChecked(m_state.forNode(node.child1()), Array::String)
/home/oszi/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp(1636) : void JSC::DFG::SpeculativeJIT::compileGetByValOnString(JSC::DFG::Node&)
1   0x7ffff6200d1e /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2013d1e) [0x7ffff6200d1e]
2   0x7ffff622d5d8 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20405d8) [0x7ffff622d5d8]
3   0x7ffff61ffb47 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2012b47) [0x7ffff61ffb47]
4   0x7ffff62002d9 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20132d9) [0x7ffff62002d9]
5   0x7ffff61d03b8 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fe33b8) [0x7ffff61d03b8]
6   0x7ffff61d1431 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fe4431) [0x7ffff61d1431]
7   0x7ffff61c41a2 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fd71a2) [0x7ffff61c41a2]
8   0x7ffff61c3683 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fd6683) [0x7ffff61c3683]
9   0x7ffff632fd29 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2142d29) [0x7ffff632fd29]
10  0x7ffff6330061 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2143061) [0x7ffff6330061]
11  0x7ffff632d976 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2140976) [0x7ffff632d976]
12  0x7ffff632cb62 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x213fb62) [0x7ffff632cb62]
13  0x7ffff60c6001 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1ed9001) [0x7ffff60c6001]
14  0x7ffff60c2b0e /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1ed5b0e) [0x7ffff60c2b0e]
15  0x7ffff6294acf /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20a7acf) [0x7ffff6294acf]
16  0x7ffff6290ab4 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20a3ab4) [0x7ffff6290ab4]
17  0x7ffff6265be0 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2078be0) [0x7ffff6265be0]
18  0x7ffff62647d3 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20777d3) [0x7ffff62647d3]
19  0x7ffff625e235 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2071235) [0x7ffff625e235]
20  0x7ffff6299815 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20ac815) [0x7ffff6299815]
21  0x7ffff6290ab4 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20a3ab4) [0x7ffff6290ab4]
22  0x7ffff6265be0 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2078be0) [0x7ffff6265be0]
23  0x7ffff6262342 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2075342) [0x7ffff6262342]
24  0x7ffff6321d37 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(_ZN3JSC8evaluateEPNS_9ExecStateERKNS_10SourceCodeENS_7JSValueEPS5_+0x1e3) [0x7ffff6321d37]
25  0x7ffff4b05544 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x918544) [0x7ffff4b05544]
26  0x7ffff4b26b89 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x939b89) [0x7ffff4b26b89]
27  0x7ffff4b26cec /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x939cec) [0x7ffff4b26cec]
28  0x7ffff4e95abc /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xca8abc) [0x7ffff4e95abc]
29  0x7ffff509a243 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xead243) [0x7ffff509a243]
30  0x7ffff509a046 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xead046) [0x7ffff509a046]
31  0x7ffff509a64e /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xead64e) [0x7ffff509a64e]
#CRASHED - WebProcess
[Thread 0x7fffa5a9b700 (LWP 31191) exited]
LEAK: 1 WebContext
LEAK: 1 WebPageProxy
[Thread 0x7ffff7ff8700 (LWP 31190) exited]
[Thread 0x7fffa589a700 (LWP 31193) exited]
[Thread 0x7fffa5e9e700 (LWP 31189) exited]
[Thread 0x7fffa609f700 (LWP 31188) exited]
[Thread 0x7fffa62a0700 (LWP 31187) exited]

Program exited with code 01.
GDB backtrace - fast/js/dfg-inline-arguments-use-from-all-the-places.html
--------------------------------------------------------------------------
$ gdb WebKitBuild/Debug/bin/WebKitTestRunner
GNU gdb (GDB) 7.0.1-debian
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /home/oszi/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner...done.
(gdb) run LayoutTests/fast/js/dfg-inline-arguments-use-from-all-the-places.html
Starting program: /home/oszi/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner LayoutTests/fast/js/dfg-inline-arguments-use-from-all-the-places.html
[Thread debugging using libthread_db enabled]
[New Thread 0x7fffa62a0700 (LWP 505)]
[New Thread 0x7fff9ffff700 (LWP 506)]
[New Thread 0x7fffa609f700 (LWP 507)]
[New Thread 0x7ffff7ff8700 (LWP 508)]
[New Thread 0x7fffa5c9c700 (LWP 509)]
[New Thread 0x7fffa5a9b700 (LWP 511)]
ASSERTION FAILED: modeAlreadyChecked(m_state.forNode(node.child1()), Array::String)
/home/oszi/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp(1636) : void JSC::DFG::SpeculativeJIT::compileGetByValOnString(JSC::DFG::Node&)
1   0x7ffff6200d1e /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2013d1e) [0x7ffff6200d1e]
2   0x7ffff622d5d8 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20405d8) [0x7ffff622d5d8]
3   0x7ffff61ffb47 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2012b47) [0x7ffff61ffb47]
4   0x7ffff62002d9 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20132d9) [0x7ffff62002d9]
5   0x7ffff61d03b8 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fe33b8) [0x7ffff61d03b8]
6   0x7ffff61d1431 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fe4431) [0x7ffff61d1431]
7   0x7ffff61c41a2 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fd71a2) [0x7ffff61c41a2]
8   0x7ffff61c3683 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fd6683) [0x7ffff61c3683]
9   0x7ffff632fd29 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2142d29) [0x7ffff632fd29]
10  0x7ffff6330061 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2143061) [0x7ffff6330061]
11  0x7ffff632d976 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2140976) [0x7ffff632d976]
12  0x7ffff632cb62 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x213fb62) [0x7ffff632cb62]
13  0x7ffff60c6001 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1ed9001) [0x7ffff60c6001]
14  0x7ffff60c2b0e /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1ed5b0e) [0x7ffff60c2b0e]
15  0x7ffff6294acf /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20a7acf) [0x7ffff6294acf]
16  0x7ffff6290ab4 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20a3ab4) [0x7ffff6290ab4]
17  0x7ffff6265be0 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2078be0) [0x7ffff6265be0]
18  0x7ffff62647d3 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20777d3) [0x7ffff62647d3]
19  0x7ffff625e235 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2071235) [0x7ffff625e235]
20  0x7ffff6299815 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20ac815) [0x7ffff6299815]
21  0x7ffff6290ab4 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20a3ab4) [0x7ffff6290ab4]
22  0x7ffff6265be0 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2078be0) [0x7ffff6265be0]
23  0x7ffff6262342 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2075342) [0x7ffff6262342]
24  0x7ffff6321d37 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(_ZN3JSC8evaluateEPNS_9ExecStateERKNS_10SourceCodeENS_7JSValueEPS5_+0x1e3) [0x7ffff6321d37]
25  0x7ffff4b05544 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x918544) [0x7ffff4b05544]
26  0x7ffff4b26b89 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x939b89) [0x7ffff4b26b89]
27  0x7ffff4b26cec /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x939cec) [0x7ffff4b26cec]
28  0x7ffff4e95abc /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xca8abc) [0x7ffff4e95abc]
29  0x7ffff509a243 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xead243) [0x7ffff509a243]
30  0x7ffff509a046 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xead046) [0x7ffff509a046]
31  0x7ffff509a64e /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xead64e) [0x7ffff509a64e]
#CRASHED - WebProcess
[Thread 0x7fffa5c9c700 (LWP 509) exited]
LEAK: 1 WebContext
LEAK: 1 WebPageProxy
[Thread 0x7ffff7ff8700 (LWP 508) exited]
[Thread 0x7fffa609f700 (LWP 507) exited]
[Thread 0x7fff9ffff700 (LWP 506) exited]
[Thread 0x7fffa62a0700 (LWP 505) exited]
[Thread 0x7fffa5a9b700 (LWP 511) exited]

Program exited with code 01.
Comment 2 Csaba Osztrogonác 2012-09-17 09:24:00 PDT
We skipped them to paint the bot green - https://trac.webkit.org/changeset/128768

Please unskip them with the proper fix.
Comment 3 Tullio Lucena 2012-10-08 15:43:52 PDT
Created attachment 167635 [details]
Patch

Unskipping tests
Comment 4 Csaba Osztrogonác 2012-10-08 23:16:28 PDT
Comment on attachment 167635 [details]
Patch

r=me.
Comment 5 Csaba Osztrogonác 2012-10-08 23:35:47 PDT
Comment on attachment 167635 [details]
Patch

Clearing flags on attachment: 167635

Committed r130722: <http://trac.webkit.org/changeset/130722>
Comment 6 Csaba Osztrogonác 2012-10-08 23:35:53 PDT
All reviewed patches have been landed.  Closing bug.