Bug 96883

Summary: [DRT][WTR] Support overriding the 'WebKitDisplayImagesKey' preference
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Fix the typo in the ChangeLog kenneth: review+

Description Chris Dumez 2012-09-16 06:12:11 PDT
EFL's DRT does not support overriding 'WebKitDisplayImagesKey' preference.

This causes the following test to fail:
fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-09-25 09:17:13 PDT
Created attachment 165624 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-09-25 09:17:58 PDT
(In reply to comment #1)
> Created an attachment (id=165624) [details]
> Patch

The patch actually contains a WK2 implementation. Unfortunately not all tests can be unskipped because WK2's testRunner does not support the queueReload() function yet.
Comment 3 Chris Dumez 2012-09-25 09:28:20 PDT
Comment on attachment 165624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165624&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL] EFL's DRT does not support overriding 'WebKitDisplayImagesKey' preference

Bug title is incorrect since this touches WK2 as well. EFL's TestRunner ?

> Source/WebKit2/ChangeLog:11
> +        WebPreferecesKey::loadsImagesAutomaticallyKey().

WebPreferecesKey ?

> LayoutTests/platform/efl-wk2/TestExpectations:195
> +webkit.org/b/42672 fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html [ Failure ]

Should not be needed, already part of wk2 Skipped file.

> LayoutTests/platform/efl-wk2/TestExpectations:196
> +webkit.org/b/42672 fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html [ Failure ]

Ditto.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-09-25 09:33:19 PDT
(In reply to comment #3)
> > Source/WebKit2/ChangeLog:11
> > +        WebPreferecesKey::loadsImagesAutomaticallyKey().
> 
> WebPreferecesKey ?

That's what the macro uses; I couldn't think of a better name to use here, though just "loadsImagesAutomatically" might be OK as well.

> > LayoutTests/platform/efl-wk2/TestExpectations:195
> > +webkit.org/b/42672 fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html [ Failure ]
> 
> Should not be needed, already part of wk2 Skipped file.
> 
> > LayoutTests/platform/efl-wk2/TestExpectations:196
> > +webkit.org/b/42672 fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html [ Failure ]
> 
> Ditto.

Right, NWRT only says the baseline search process is efl-wk2 -> efl -> generic, and I wasn't sure generic was wk2.
Comment 5 Chris Dumez 2012-09-25 09:43:27 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > > Source/WebKit2/ChangeLog:11
> > > +        WebPreferecesKey::loadsImagesAutomaticallyKey().
> > 
> > WebPreferecesKey ?
> 
> That's what the macro uses; I couldn't think of a better name to use here, though just "loadsImagesAutomatically" might be OK as well.

I mean it looks like there is a typo. it's missing a 'n' in Preferences.

> > > LayoutTests/platform/efl-wk2/TestExpectations:195
> > > +webkit.org/b/42672 fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html [ Failure ]
> > 
> > Should not be needed, already part of wk2 Skipped file.
> > 
> > > LayoutTests/platform/efl-wk2/TestExpectations:196
> > > +webkit.org/b/42672 fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html [ Failure ]
> > 
> > Ditto.
> 
> Right, NWRT only says the baseline search process is efl-wk2 -> efl -> generic, and I wasn't sure generic was wk2.

Yes, I confirm that WebKit2 EFL uses wk2 Skipped file. It is indeed missing from our wiki, we should fix that.
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-09-25 09:44:02 PDT
Created attachment 165633 [details]
Patch
Comment 7 Raphael Kubo da Costa (:rakuco) 2012-09-25 09:56:26 PDT
Created attachment 165635 [details]
Fix the typo in the ChangeLog
Comment 8 Chris Dumez 2012-09-25 10:04:49 PDT
Comment on attachment 165635 [details]
Fix the typo in the ChangeLog

LGTM.
Comment 9 Raphael Kubo da Costa (:rakuco) 2012-09-26 00:41:03 PDT
Committed r129605: <http://trac.webkit.org/changeset/129605>