Bug 96874

Summary: Teach style checker about #ifdef/#ifndef/#else/etc indentation rules
Product: WebKit Reporter: Philip Rogers <pdr>
Component: Tools / TestsAssignee: Philip Rogers <pdr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, levin, ojan, webkit.review.bot
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Teach style checker about preprocessor directive indentation rules none

Philip Rogers
Reported 2012-09-15 18:26:35 PDT
Our codebase has no instances of indented #ifdef/#ifndef. We should teach the style checker to enforce this.
Attachments
Teach style checker about preprocessor directive indentation rules (5.21 KB, patch)
2012-09-15 19:52 PDT, Philip Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philip Rogers
Comment 1 2012-09-15 19:52:17 PDT
Created attachment 164302 [details] Teach style checker about preprocessor directive indentation rules
WebKit Review Bot
Comment 2 2012-09-17 11:25:57 PDT
Comment on attachment 164302 [details] Teach style checker about preprocessor directive indentation rules Clearing flags on attachment: 164302 Committed r128782: <http://trac.webkit.org/changeset/128782>
WebKit Review Bot
Comment 3 2012-09-17 11:26:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.