Bug 96858

Summary: JSC: Windows port needs a proper JSLock implementation
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: levin+threading, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix. fpizlo: review+

Mark Lam
Reported 2012-09-15 01:07:24 PDT
Currently, the JSLock methods are implemented for platforms that support pthreads. As a result, the Windows port is only using a stub JSLock that does nothing. This stub implementation causes ASSERT(!m_apiLock.currentThreadIsHoldingLock()) (in JSGlobalData::~JSGlobalData()) to always fail. In addition, the stub JSLock implementation does not provide the needed synchronization, and as a result, the Windows port crashes or fails in intermittent ways when running the layout tests.
Attachments
Fix. (5.23 KB, patch)
2012-09-15 22:25 PDT, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2012-09-15 01:09:11 PDT
<rdar://problem/12297283>
Mark Lam
Comment 2 2012-09-15 22:25:32 PDT
Created attachment 164307 [details] Fix.
Mark Lam
Comment 3 2012-09-15 23:31:43 PDT
Committed r128704: <http://trac.webkit.org/changeset/128704>
Note You need to log in before you can comment on or make changes to this bug.