Bug 96801

Summary: [CSS Shaders] Refactor FECustomFilter to make it usable from platform dependent implementations
Product: WebKit Reporter: Alexandru Chiculita <achicu>
Component: Layout and RenderingAssignee: Alexandru Chiculita <achicu>
Severity: Normal CC: dino, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch V1
Patch V2
Patch V3 dino: review+

Description Alexandru Chiculita 2012-09-14 09:56:37 PDT
Refactoring the code in FECustomFilter to make it easy to use from FECustomFilterSkia.
Comment 1 Alexandru Chiculita 2012-09-14 10:08:27 PDT
Created attachment 164176 [details]
Patch V1
Comment 2 Alexandru Chiculita 2012-09-14 10:10:47 PDT
Created attachment 164178 [details]
Patch V2

I forgot to remove the Skia method in FECustomFilter.h. Fixed it now.
Comment 3 Alexandru Chiculita 2012-09-14 10:25:52 PDT
Created attachment 164184 [details]
Patch V3

Comment 4 Dean Jackson 2012-09-14 11:28:40 PDT
Comment on attachment 164184 [details]
Patch V3

View in context: https://bugs.webkit.org/attachment.cgi?id=164184&action=review

I didn't look through this so carefully since I'd already done it in the original bug :)

> Source/WebCore/platform/graphics/filters/FECustomFilter.cpp:185
> +    // Only allocate a texture if the program needs one and the caller doesn't allocate one by itself.
> +    if (programNeedsInputTexture() && (filterDrawType == NEEDS_INPUT_TEXTURE) && !ensureInputTexture())
> +        return false;
> +    if (!ensureFrameBuffer())
> +        return false;

Any reason why we don't merge that into one test?
Comment 5 Alexandru Chiculita 2012-09-14 11:54:34 PDT
Comment on attachment 164184 [details]
Patch V3

Thanks Dean!
Comment 6 Alexandru Chiculita 2012-09-14 12:35:17 PDT
Landed in http://trac.webkit.org/changeset/128641 .