Summary: | [CSS Shaders] Refactor FECustomFilter to make it usable from platform dependent implementations | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexandru Chiculita <achicu> | ||||||||
Component: | Layout and Rendering | Assignee: | Alexandru Chiculita <achicu> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dino, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alexandru Chiculita
2012-09-14 09:56:37 PDT
Created attachment 164176 [details]
Patch V1
Created attachment 164178 [details]
Patch V2
I forgot to remove the Skia method in FECustomFilter.h. Fixed it now.
Created attachment 164184 [details]
Patch V3
Rebased.
Comment on attachment 164184 [details] Patch V3 View in context: https://bugs.webkit.org/attachment.cgi?id=164184&action=review I didn't look through this so carefully since I'd already done it in the original bug :) > Source/WebCore/platform/graphics/filters/FECustomFilter.cpp:185 > + // Only allocate a texture if the program needs one and the caller doesn't allocate one by itself. > + if (programNeedsInputTexture() && (filterDrawType == NEEDS_INPUT_TEXTURE) && !ensureInputTexture()) > + return false; > + if (!ensureFrameBuffer()) > + return false; Any reason why we don't merge that into one test? Comment on attachment 164184 [details]
Patch V3
Thanks Dean!
Landed in http://trac.webkit.org/changeset/128641 . |