Bug 96788

Summary: Gesture events sent to wrong node when page is scrolled
Product: WebKit Reporter: Rick Byers <rbyers>
Component: UI EventsAssignee: Rick Byers <rbyers>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, allan.jensen, sadrul, tonikitoo, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96060    
Attachments:
Description Flags
Patch none

Description Rick Byers 2012-09-14 07:48:09 PDT
In bug 92281, gesture events started being propagated to the DOM, just for the sake of chromium plugins.  However the hit test that occurs here is happening on the wrong co-ordinate space, so if the page is scrolled, the wrong DOM element will be targeted.
Comment 1 Rick Byers 2012-09-14 08:00:21 PDT
In the new layout test I'm about to upload, we currently get the following output (only the unexpected GestureTapDown, and the synthetic mouse events are received):
Plugin received event: GestureTapDown
Plugin received event: MouseEnter
Plugin received event: MouseMove
Plugin received event: MouseDown
Plugin received event: MouseUp
Plugin received event: MouseWheel

With the fix, we get this as expected:
Plugin received event: GestureTap
Plugin received event: MouseEnter
Plugin received event: MouseMove
Plugin received event: MouseDown
Plugin received event: MouseUp
Plugin received event: GestureScrollBegin
Plugin received event: GestureScrollUpdate
Plugin received event: MouseWheel
Plugin received event: GestureScrollEnd
Comment 2 Rick Byers 2012-09-14 08:13:54 PDT
Created attachment 164155 [details]
Patch
Comment 3 Rick Byers 2012-09-14 08:15:06 PDT
abarth@, since you reviewed the original change  in bug 92281, do you want to review this one two?
Comment 4 WebKit Review Bot 2012-09-14 08:54:46 PDT
Comment on attachment 164155 [details]
Patch

Clearing flags on attachment: 164155

Committed r128615: <http://trac.webkit.org/changeset/128615>
Comment 5 WebKit Review Bot 2012-09-14 08:54:49 PDT
All reviewed patches have been landed.  Closing bug.