Bug 96787

Summary: [GTK] Don't use the C API internally in WebKitURISchemeRequest
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mario, mrobinson, webkit.review.bot
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 96786    
Bug Blocks: 96766    
Attachments:
Description Flags
Patch
none
Updated patch to build on current git master gustavo: review+

Carlos Garcia Campos
Reported 2012-09-14 07:38:33 PDT
Use the C++ classes instead.
Attachments
Patch (6.43 KB, patch)
2012-09-14 07:39 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch to build on current git master (7.39 KB, patch)
2012-10-16 01:48 PDT, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-09-14 07:39:50 PDT
Created attachment 164153 [details] Patch This is the last one.
WebKit Review Bot
Comment 2 2012-09-14 07:43:46 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Mario Sanchez Prada
Comment 3 2012-10-03 01:53:06 PDT
Comment on attachment 164153 [details] Patch Looks good to me
Carlos Garcia Campos
Comment 4 2012-10-16 01:48:16 PDT
Created attachment 168892 [details] Updated patch to build on current git master Updated after the initiating page patch.
Carlos Garcia Campos
Comment 5 2012-10-17 08:37:45 PDT
Committed r131603: <http://trac.webkit.org/changeset/131603>
Note You need to log in before you can comment on or make changes to this bug.