Bug 96767

Summary: [GTK] Don't use the C API internally in WebKitWebView
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mario, mrobinson, webkit.review.bot
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 96766, 96768    
Attachments:
Description Flags
Patch gustavo: review+

Carlos Garcia Campos
Reported 2012-09-14 06:32:01 PDT
Use the C++ classes instead.
Attachments
Patch (40.94 KB, patch)
2012-09-14 06:35 PDT, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-09-14 06:35:04 PDT
Created attachment 164126 [details] Patch This is the first of a series of commits to stop using the C API internally.
WebKit Review Bot
Comment 2 2012-09-14 06:38:01 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Philippe Normand
Comment 3 2012-09-21 09:55:58 PDT
Comment on attachment 164126 [details] Patch LGTM!
Carlos Garcia Campos
Comment 4 2012-09-25 00:18:01 PDT
Thank you very much Gustavo.
Carlos Garcia Campos
Comment 5 2012-09-25 01:34:21 PDT
Committed r129475: <http://trac.webkit.org/changeset/129475>
Note You need to log in before you can comment on or make changes to this bug.