Bug 96762

Summary: [EFL][WK2] Unskip test cases that are now passing
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
Patch none

Description Sudarsana Nagineni (babu) 2012-09-14 06:18:06 PDT
1) fast/events/keyevent-iframe-removed-crash.html is passing after r128513. 

2) New test introduced in r128580 http/tests/inspector/network/network-xhr-replay.html crashes on EFL debug bots.

Here is the stack trace:
http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug/r128580%20%285896%29/http/tests/inspector/network/network-xhr-replay-crash-log.txt

crash log for DumpRenderTree (pid 25944):
STDOUT: <empty>
STDERR: ASSERTION FAILED: m_method != "GET"
STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/xml/XMLHttpRequest.cpp(729) : void WebCore::XMLHttpRequest::createRequest(WebCore::ExceptionCode&)
STDERR: 1   0x7ff82129cbaf WebCore::XMLHttpRequest::createRequest(int&)
STDERR: 2   0x7ff82129c75d WebCore::XMLHttpRequest::sendFromInspector(WTF::PassRefPtr<WebCore::FormData>, int&)
STDERR: 3   0x7ff820c08abe WebCore::InspectorResourceAgent::replayXHR(WTF::String*, WTF::String const&)
STDERR: 4   0x7ff8217acec5 WebCore::InspectorBackendDispatcherImpl::Network_replayXHR(long, WebCore::InspectorObject*)
STDERR: 5   0x7ff8217c5e35 WebCore::InspectorBackendDispatcherImpl::dispatch(WTF::String const&)
STDERR: 6   0x7ff820bae4f2 WebCore::InspectorController::dispatchMessageFromFrontend(WTF::String const&)
STDERR: 7   0x7ff820bdfb68 WebCore::InspectorBackendDispatchTask::onTimer(WebCore::Timer<WebCore::InspectorBackendDispatchTask>*)
STDERR: 8   0x7ff820be1fe8 WebCore::Timer<WebCore::InspectorBackendDispatchTask>::fired()
STDERR: 9   0x7ff820e09611 WebCore::ThreadTimers::sharedTimerFiredInternal()
STDERR: 10  0x7ff820e0953f WebCore::ThreadTimers::sharedTimerFired()
STDERR: 11  0x7ff82175610d
STDERR: 12  0x7ff81dd61c4e _ecore_timer_expired_call
STDERR: 13  0x7ff81dd61e1b _ecore_timer_expired_timers_call
STDERR: 14  0x7ff81dd5eeb1
STDERR: 15  0x7ff81dd5f547 ecore_main_loop_begin
STDERR: 16  0x476b41
STDERR: 17  0x476d1f
STDERR: 18  0x477378 main
STDERR: 19  0x7ff81c40e76d __libc_start_main
STDERR: 20  0x464669
Comment 1 Sudarsana Nagineni (babu) 2012-09-14 06:29:29 PDT
Created attachment 164125 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-14 07:04:13 PDT
Comment on attachment 164125 [details]
Patch

Rejecting attachment 164125 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 156485.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
LayoutTests/platform/efl/TestExpectations:173:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 1 files

Full output: http://queues.webkit.org/results/13861036
Comment 3 Sudarsana Nagineni (babu) 2012-09-14 08:04:03 PDT
> LayoutTests/platform/efl/TestExpectations:173:  Path does not exist. 

http/tests/inspector/network/network-xhr-replay.html has already been disabled in r128601. I will consider this bug only for unskip test cases that are now passing consistently.
Comment 4 Sudarsana Nagineni (babu) 2012-09-14 08:14:33 PDT
Created attachment 164157 [details]
Patch
Comment 5 WebKit Review Bot 2012-09-14 08:38:17 PDT
Comment on attachment 164157 [details]
Patch

Clearing flags on attachment: 164157

Committed r128613: <http://trac.webkit.org/changeset/128613>
Comment 6 WebKit Review Bot 2012-09-14 08:38:21 PDT
All reviewed patches have been landed.  Closing bug.