Bug 96759

Summary: Web Inspector: NMI: convert template versions of String*::reportMemoryUsage functions to normal functions.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Severity: Normal CC: alph, apavlov, benjamin, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
yurys: review+, buildbot: commit-queue-
for trybots none

Description Ilya Tikhonovsky 2012-09-14 05:19:38 PDT
Initially reportMemoryUsage functions in AtomicString, WTFString and StringBuffer were template functions.
Otherwise I had to include MemoryInstrumentation.h from WebCore.
Now the core NMI code is in WTF and I can include the header and move the bodies to cpp files.
Comment 1 Ilya Tikhonovsky 2012-09-14 05:24:28 PDT
Created attachment 164113 [details]
Comment 2 Build Bot 2012-09-14 05:53:50 PDT
Comment on attachment 164113 [details]

Attachment 164113 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13855413
Comment 3 Build Bot 2012-09-14 06:01:43 PDT
Comment on attachment 164113 [details]

Attachment 164113 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13841744
Comment 4 Ilya Tikhonovsky 2012-09-14 06:08:47 PDT
Created attachment 164124 [details]
for trybots
Comment 5 Ilya Tikhonovsky 2012-09-14 07:08:08 PDT
Committed r128609: <http://trac.webkit.org/changeset/128609>