| Summary: | Refactor time format related methods on LocaleWin/Mac/ICU so that they override Localizer methods | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keishi Hattori <keishi> | ||||||
| Component: | Forms | Assignee: | Keishi Hattori <keishi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | roger_fong, tkent, webkit.review.bot, yosin | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 96351, 96728 | ||||||||
| Attachments: |
|
||||||||
|
Description
Keishi Hattori
2012-09-13 22:27:33 PDT
Created attachment 164048 [details]
Patch
Comment on attachment 164048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164048&action=review ok > Source/WebCore/ChangeLog:34 > + * platform/text/LocaleICU.cpp: > + (WebCore::LocaleICU::initializeDateTimeFormat): > + (WebCore::LocaleICU::timeFormatText): > + (WebCore::LocaleICU::shortTimeFormatText): > + (WebCore::LocaleICU::timeAMPMLabels): > + * platform/text/LocaleICU.h: > + (LocaleICU): > + * platform/text/LocaleWin.h: > + (LocaleWin): > + * platform/text/LocalizedDateICU.cpp: > + (WebCore::localizedTimeFormatText): > + (WebCore::localizedShortTimeFormatText): > + * platform/text/Localizer.cpp: > + (WebCore): > + (WebCore::Localizer::timeFormatText): > + (WebCore::Localizer::shortTimeFormatText): > + (WebCore::Localizer::timeAMPMLabels): > + * platform/text/Localizer.h: > + (Localizer): > + * platform/text/mac/LocaleMac.h: > + (LocaleMac): Please write what is changed for each files/functions as possible. Could you use timeFormat and shortTimeFormat instead of timeFormatText and shortTimeFormatText? Because, timeFormatText() and shortTimeFormatText() returns LDML format. The localizedDateFormatText() returns human readable text, e.g. Day/Month/Year. Thanks in advance! Created attachment 164092 [details]
Patch
Comment on attachment 164092 [details]
Patch
ok
Comment on attachment 164092 [details] Patch Clearing flags on attachment: 164092 Committed r128584: <http://trac.webkit.org/changeset/128584> All reviewed patches have been landed. Closing bug. Hello, Currently there are one of two revisions that are causing the Windows test bots to exit early after 20 crashes. This is one possible candidate. Do you think this could have caused a large quantity of accessibility tests on Windows 7 to start failing all of a sudden? The Windows bots have suddenly gotten into a terrible state so if you could verify this quickly I'd be greatly appreciative. Thanks Here are the failing tests: accessibility/accessibility-node-memory-management.html: [object DocumentFragment] accessibility/accessibility-node-reparent.html: [object DocumentFragment] accessibility/accessibility-object-detached.html: [object DocumentFragment] accessibility/adjacent-continuations-cause-assertion-failure.html: [object DocumentFragment] accessibility/anchor-linked-anonymous-block-crash.html: [object DocumentFragment] accessibility/anonymous-render-block-in-continuation-causes-crash.html: [object DocumentFragment] accessibility/aria-activedescendant-crash.html: [object DocumentFragment] accessibility/aria-checkbox-checked.html: [object DocumentFragment] accessibility/aria-fallback-roles.html: [object DocumentFragment] accessibility/aria-hidden-update.html: [object DocumentFragment] accessibility/aria-hidden-updates-alldescendants.html: [object DocumentFragment] accessibility/aria-labelledby-overrides-aria-label.html: [object DocumentFragment] accessibility/canvas-accessibilitynodeobject.html: [object DocumentFragment] accessibility/canvas-description-and-role.html: [object DocumentFragment] accessibility/canvas-fallback-content.html: [object DocumentFragment] accessibility/content-changed-notification-causes-crash.html: [object DocumentFragment] accessibility/contenteditable-hidden-div.html: [object DocumentFragment] accessibility/contenteditable-table-check-causes-crash.html: [object DocumentFragment] accessibility/crash-determining-aria-role-when-label-present.html: [object DocumentFragment] Issue was fixed, thanks! |