Bug 96682

Summary:

Add a style guide rule for signed and unsigned int

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

New Bugs

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, kenneth, mitz

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+

Ryosuke Niwa

Reported 2012-09-13 12:26:30 PDT

Add a style guide rule for signed and unsigned int

Attachments
Patch (1.42 KB, patch) 2012-09-13 12:27 PDT, Ryosuke Niwa	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2012-09-13 12:27:32 PDT

Geoffrey Garen

Comment 2 2012-09-13 12:49:43 PDT

Ryosuke Niwa

Comment 3 2012-09-13 13:17:09 PDT

Darin Adler

Comment 4 2012-09-13 13:31:32 PDT

Ryosuke Niwa

Comment 5 2012-09-13 13:49:29 PDT

Fixed the typo in r128503.

Daniel Bates

Comment 6 2012-09-13 13:55:33 PDT

Comment on attachment 163935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163935&action=review > Websites/webkit.org/coding/coding-style.html:1055 > +Omit "int" when using "unsigned" modifier. Do not use "signed" modifier. Use "int" by itself instead. We should be explicit about not using the "signed" modifier for integer types. This part of the rule shouldn't be applied to objects of type char used in a bit-fields by bug 54807 comment 9 (*). (*) For completeness, Final Committee Draft of "ISO/IEC IS 14882 – Programming Languages – C++" (28 February 2011) is at <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2011/n3242.pdf>. Bug 54807 comment 9 references an incorrect URL that was corrected in bug 54807 comment 10). For completeness, a newer

Note You need to log in before you can comment on or make changes to this bug.